Few more job tests WRT delay and FIFO.

Author: metaskills

Rakefile

@@ -5,7 +5,7 @@ require "rake/testtask"
 Rake::TestTask.new(:test) do |t|
   t.libs << "test"
   t.libs << "lib"
-  t.test_files = FileList["test/cases/*_test.rb"]
+  t.test_files = FileList["test/cases/**/*_test.rb"]
   t.verbose = false
   t.warning = false
 end

TODO.md

@@ -44,6 +44,10 @@ end
   - FIFO: 256 KB??
 * Setting `maxReceiveCount` hard codes your retries to -1 of that value at the queue level.
 
+Q: How do I handle job priorities?
+A: Use different queues.
+
+
 ## Our Siqekiq Interfaces
 
 ```ruby
@@ -61,6 +65,14 @@ DO I MIRROR or MIGRATE
 
 ## Migrating from Sidekiq
 
+#### Change Worker
+
+```ruby
+class ApplicationJob < ActiveJob::Base
+  include Sidekiq::Worker
+  include Lambdakiq::Worker
+end
+```
 
 #### Single Job
 

lib/lambdakiq.rb

@@ -14,6 +14,7 @@
 require 'lambdakiq/record'
 require 'lambdakiq/backoff'
 require 'lambdakiq/metrics'
+require 'lambdakiq/worker'
 require 'rails/railtie'
 require 'lambdakiq/railtie'
 

lib/lambdakiq/worker.rb

@@ -0,0 +1,5 @@
+module Lambdakiq
+  module Worker
+
+  end
+end

test/cases/jobs/basic_job_delay_test.rb

@@ -0,0 +1,15 @@
+require 'test_helper'
+
+class BasicJobDelayTest < LambdakiqSpec
+  before do
+    TestHelper::Jobs::BasicJob.set(wait: 5.minutes).perform_later('somework')
+    expect(sent_message).must_be :present?
+  end
+
+  it 'message attributes include `delay_seconds` since no wait was set' do
+    delay_seconds = sent_message_attributes['delay_seconds']
+    expect(delay_seconds).must_be :present?
+    expect(delay_seconds[:data_type]).must_equal 'String'
+    expect(delay_seconds[:string_value]).must_equal '300'
+  end
+end

test/cases/jobs/basic_job_nofifo_delay_test.rb

@@ -0,0 +1,17 @@
+require 'test_helper'
+
+class BasicJobNofifoDelayTest < LambdakiqSpec
+  before do
+    TestHelper::Jobs::BasicNofifoJob.set(wait: 5.minutes).perform_later('somework')
+    expect(sent_message).must_be :present?
+  end
+
+  it 'uses default `delay_seconds` since non-FIFO queues support this natively' do
+    expect(sent_message_params[:delay_seconds]).must_equal 300
+  end
+
+  it 'message attributes exclude `delay_seconds` since non-FIFO queues support this natively' do
+    delay_seconds = sent_message_attributes['delay_seconds']
+    expect(delay_seconds).must_be_nil
+  end
+end

test/cases/basic_nofifo_job_test.rb renamed to test/cases/jobs/basic_job_nofifo_job_test.rb

@@ -1,8 +1,9 @@
 require 'test_helper'
 
-class BasicNofifoJobTest < LambdakiqSpec
+class BasicJobNofifoTest < LambdakiqSpec
   before do
     TestHelper::Jobs::BasicNofifoJob.perform_later('somework')
+    expect(sent_message).must_be :present?
   end
 
   it 'message body has no fifo queue nave vs fifo super class ' do

test/cases/basic_job_test.rb renamed to test/cases/jobs/basic_job_test.rb

@@ -19,6 +19,10 @@ class BasicJobTest < LambdakiqSpec
     expect(lambdakiq[:string_value]).must_equal '1'
   end
 
+  it 'message attributes do not include `delay_seconds` since no wait was set' do
+    expect(sent_message_attributes.key?('delay_seconds')).must_equal false
+  end
+
   it 'message group and deduplication id for default fifo queue are sent' do
     expect(sent_message_params[:message_group_id]).must_equal 'LambdakiqMessage'
     expect(sent_message_params[:message_deduplication_id]).must_be :present?

test/cases/queue_test.rb

@@ -1,8 +1,13 @@
 require 'test_helper'
 
 class QueueTest < LambdakiqSpec
+  let(:queue) { Lambdakiq.client.queues[queue_name] }
+
+  it '#fifo?' do
+    expect(queue.fifo?).must_equal true
+  end
+
   it '#max_receive_count' do
-    queue = Lambdakiq.client.queues[queue_name]
     expect(queue.max_receive_count).must_equal 8
   end
 end

test/test_helper/jobs/basic_nofifo_job.rb

@@ -1,7 +1,7 @@
 module TestHelper
   module Jobs
     class BasicNofifoJob < ApplicationJob
-      queue_as 'lambdakiq-JobsQueue-TESTING123'
+      queue_as ENV['TEST_QUEUE_NAME'].sub('.fifo','')
       def perform(object)
         object
       end