File tree Expand file tree Collapse file tree 4 files changed +17
-5
lines changed Expand file tree Collapse file tree 4 files changed +17
-5
lines changed Original file line number Diff line number Diff line change @@ -24,11 +24,9 @@ def _enqueue(job, send_message_opts = {})
24
24
end
25
25
```
26
26
27
- * Use job's ` attr_accessor :executions ` vs ` ApproximateReceiveCount `
28
27
* Error handlers. Ensure we easily hook into Rollbar, etc.
29
- * Is ` delete_message ` message needed? Is 200 from consumer implied delete?
30
28
* Can I set Rails tempalte ` VisibilityTimeout ` to just +1 of function timeout or full 43200?
31
- * Can I get rid of the Job re-raising and rely on change message visibility alone?
29
+ * Do this in our gem. ` ActiveJob::Base.logger = Logger.new(IO::NULL) `
32
30
33
31
## Doc Points
34
32
@@ -60,7 +58,6 @@ DO I MIRROR or MIGRATE
60
58
## Max Retries
61
59
62
60
* Max is twelve.
63
- *
64
61
65
62
## Migrating from Sidekiq
66
63
Original file line number Diff line number Diff line change 4
4
require 'active_job/queue_adapters'
5
5
require 'active_support/all'
6
6
require 'lambdakiq/version'
7
+ require 'lambdakiq/error'
7
8
require 'lambdakiq/adapter'
8
9
require 'lambdakiq/client'
9
10
require 'lambdakiq/queue'
Original file line number Diff line number Diff line change
1
+ module Lambdakiq
2
+ class Error < StandardError
3
+ attr_reader :original_exception , :job
4
+
5
+ def initialize ( error )
6
+ @original_exception = error
7
+ super ( error . message )
8
+ set_backtrace Rails . backtrace_cleaner . clean ( error . backtrace )
9
+ end
10
+ end
11
+
12
+ class JobError < Error ; end
13
+ end
Original file line number Diff line number Diff line change @@ -10,7 +10,8 @@ def handler(event)
10
10
jobs = records . map { |record | new ( record ) }
11
11
jobs . each ( &:perform )
12
12
jwerror = jobs . detect { |j | j . error }
13
- jwerror ? raise ( jwerror . error ) : true
13
+ return unless jwerror
14
+ raise JobError . new ( jwerror . error )
14
15
end
15
16
16
17
end
You can’t perform that action at this time.
0 commit comments