Fix isSSLAvailable() so it's good enough for "ant test-ssl"

That said, it's probably too limited for "mvn test". This method will
need to be adapted to how Maven handles external properties.

Author: dumbbell

src/test/java/com/rabbitmq/client/test/AbstractRMQTestSuite.java

@@ -12,8 +12,9 @@
 import org.junit.Assume;
 
 public abstract class AbstractRMQTestSuite extends TestSuite {
-  private static final int DEFAULT_SSL_PORT = 443;
-  
+  private static final String DEFAULT_SSL_HOSTNAME = "localhost";
+  private static final int DEFAULT_SSL_PORT = 5671;
+
   private static boolean buildPropertiesFound = false;
 
   private static final Properties TESTS_PROPS = new Properties(System.getProperties());
@@ -37,14 +38,19 @@ public static boolean isUnderUmbrella() {
     return new File("../../UMBRELLA.md").isFile();
   }
 
-  public static boolean isSSlAvailable() {
+  public static boolean isSSLAvailable() {
+    /*
+     * FIXME: This method tries to reproduce what was done in Ant's
+     * build.xml. It's probably not enough to have a working SSL
+     * testsuite with Maven.
+     */
     System.setProperty("SSL_CERTS_DIR", System.getenv("SSL_CERTS_DIR"));
-    String sslClientPath = System.getProperty("SSL_CERTS_DIR") + FileSystems.getDefault().getSeparator() + "client";
-    System.setProperty("CLIENT_KEYSTORE_PHRASE", System.getenv("bunnies"));
-    System.setProperty("SSL_P12_PASSWORD", System.getenv("PASSWORD"));
-    // IF certificate is present and some server is listening on port 443
-    if (new File(sslClientPath).isFile() && checkServerListening(System.getProperty("broker.hostname"), DEFAULT_SSL_PORT)) {
-      System.setProperty("SSL_AVAILABLE", sslClientPath);
+    String sslClientCertsDir = System.getProperty("SSL_CERTS_DIR") +
+      FileSystems.getDefault().getSeparator() + "client";
+    // If certificate is present and some server is listening on port 5671
+    if (new File(sslClientCertsDir).exists() &&
+        checkServerListening(DEFAULT_SSL_HOSTNAME, DEFAULT_SSL_PORT)) {
+      System.setProperty("SSL_AVAILABLE", sslClientCertsDir);
       return true;
     } else
       return false;

src/test/java/com/rabbitmq/client/test/ssl/SSLTests.java

@@ -25,7 +25,7 @@ public class SSLTests extends AbstractRMQTestSuite {
     public static TestSuite suite() {
         TestSuite suite = new TestSuite("ssl");
         //Skip the tests if not under umbrella and not SSL available
-        if(!(isUnderUmbrella() && isSSlAvailable())) return suite;
+        if(!(isUnderUmbrella() && isSSLAvailable())) return suite;
         suite.addTestSuite(UnverifiedConnection.class);
         suite.addTestSuite(VerifiedConnection.class);
         suite.addTestSuite(BadVerifiedConnection.class);