feat: expose more configuration options

Author: metacosm

core/runtime/src/main/java/io/quarkiverse/operatorsdk/runtime/BuildTimeOperatorConfiguration.java

@@ -24,20 +24,36 @@ public class BuildTimeOperatorConfiguration {
 
     /**
      * Whether controllers should only process events if the associated resource generation has
-     * increased since last reconciliation, otherwise will process all events. Sets the default value for all controllers.
+     * increased since last reconciliation, otherwise will process all events. Sets the default value
+     * for all controllers.
      */
     @ConfigItem(defaultValue = "true")
     public Optional<Boolean> generationAware;
 
     /**
-     * Whether Role-Based Access Control (RBAC) resources should be generated in the kubernetes manifests.
+     * Whether Role-Based Access Control (RBAC) resources should be generated in the kubernetes
+     * manifests.
      */
     @ConfigItem(defaultValue = "false")
     public Boolean disableRbacGeneration;
 
     /**
-     * Whether the operator should be automatically started or not. Mostly useful for testing scenarios.
+     * Whether the operator should be automatically started or not. Mostly useful for testing
+     * scenarios.
      */
     @ConfigItem
     public Optional<Boolean> startOperator;
+
+    /**
+     * Whether the injected Kubernetes client should be stopped when the operator is stopped.
+     */
+    @ConfigItem(defaultValue = "true")
+    public Boolean closeClientOnStop;
+
+    /**
+     * Whether the operator should stop if an informer error (such as one caused by missing / improper
+     * RBACs) occurs during startup.
+     */
+    @ConfigItem(defaultValue = "true")
+    public Boolean stopOnInformerErrorDuringStartup;
 }

core/runtime/src/main/java/io/quarkiverse/operatorsdk/runtime/ConfigurationServiceRecorder.java

@@ -33,6 +33,9 @@ public Supplier<QuarkusConfigurationService> configurationServiceSupplier(Versio
                 .orElse(ConfigurationService.DEFAULT_RECONCILIATION_THREADS_NUMBER);
         final var timeout = runTimeConfiguration.terminationTimeoutSeconds
                 .orElse(ConfigurationService.DEFAULT_TERMINATION_TIMEOUT_SECONDS);
+        final var workflowThreads = runTimeConfiguration.concurrentWorkflowThreads
+                .orElse(ConfigurationService.DEFAULT_WORKFLOW_EXECUTOR_THREAD_NUMBER);
+        final var cacheSyncTimeout = runTimeConfiguration.cacheSyncTimeout;
 
         configurations.forEach((name, c) -> {
             final var extConfig = runTimeConfiguration.controllers.get(name);
@@ -73,7 +76,8 @@ public Supplier<QuarkusConfigurationService> configurationServiceSupplier(Versio
             final var mapper = Serialization.jsonMapper();
             mapper.disable(SerializationFeature.FAIL_ON_EMPTY_BEANS);
             final var container = Arc.container();
-            container.select(ObjectMapperCustomizer.class, KubernetesClientSerializationCustomizer.Literal.INSTANCE)
+            container.select(ObjectMapperCustomizer.class,
+                    KubernetesClientSerializationCustomizer.Literal.INSTANCE)
                     .stream()
                     .sorted()
                     .forEach(c -> c.customize(mapper));
@@ -84,12 +88,16 @@ public Supplier<QuarkusConfigurationService> configurationServiceSupplier(Versio
                     container.instance(KubernetesClient.class).get(),
                     crdInfo,
                     maxThreads,
+                    workflowThreads,
                     timeout,
+                    cacheSyncTimeout,
                     container.instance(Metrics.class).get(),
                     shouldStartOperator(buildTimeConfiguration.startOperator, launchMode),
                     mapper,
                     container.instance(LeaderElectionConfiguration.class).orElse(null),
-                    container.instance(InformerStoppedHandler.class).orElse(null));
+                    container.instance(InformerStoppedHandler.class).orElse(null),
+                    buildTimeConfiguration.closeClientOnStop,
+                    buildTimeConfiguration.stopOnInformerErrorDuringStartup);
         };
     }
 

core/runtime/src/main/java/io/quarkiverse/operatorsdk/runtime/QuarkusConfigurationService.java

@@ -1,5 +1,6 @@
 package io.quarkiverse.operatorsdk.runtime;
 
+import java.time.Duration;
 import java.util.Collection;
 import java.util.Collections;
 import java.util.HashMap;
@@ -37,16 +38,23 @@ public class QuarkusConfigurationService extends AbstractConfigurationService {
     private final boolean startOperator;
     private final LeaderElectionConfiguration leaderElectionConfiguration;
     private final InformerStoppedHandler informerStoppedHandler;
+    private final boolean closeClientOnStop;
+    private final boolean stopOnInformerErrorDuringStartup;
+    private final int concurrentWorkflowExecutorThreads;
+    private final Duration cacheSyncTimeout;
 
     @SuppressWarnings({ "rawtypes", "unchecked" })
     public QuarkusConfigurationService(
             Version version,
             Collection<QuarkusControllerConfiguration> configurations,
             KubernetesClient client,
-            CRDGenerationInfo crdInfo, int maxThreads,
-            int timeout, Metrics metrics, boolean startOperator, ObjectMapper mapper,
-            LeaderElectionConfiguration leaderElectionConfiguration, InformerStoppedHandler informerStoppedHandler) {
+            CRDGenerationInfo crdInfo, int maxThreads, int maxWorflowThreads,
+            int timeout, Duration cacheSyncTimeout, Metrics metrics, boolean startOperator, ObjectMapper mapper,
+            LeaderElectionConfiguration leaderElectionConfiguration, InformerStoppedHandler informerStoppedHandler,
+            boolean closeClientOnStop, boolean stopOnInformerErrorDuringStartup) {
         super(version);
+        this.closeClientOnStop = closeClientOnStop;
+        this.stopOnInformerErrorDuringStartup = stopOnInformerErrorDuringStartup;
         final var cloner = new Cloner() {
             @Override
             public <R extends HasMetadata> R clone(R r) {
@@ -62,17 +70,21 @@ public <R extends HasMetadata> R clone(R r) {
         this.client = client;
         this.metrics = metrics;
         if (configurations != null && !configurations.isEmpty()) {
-            reconcilerClassToName = new HashMap<>(configurations.size());
+            final var size = configurations.size();
+            reconcilerClassToName = new HashMap<>(size);
             configurations.forEach(c -> {
-                reconcilerClassToName.put(c.getAssociatedReconcilerClassName(), c.getName());
+                final var name = c.getName();
+                reconcilerClassToName.put(c.getAssociatedReconcilerClassName(), name);
                 register(c);
             });
         } else {
             reconcilerClassToName = Collections.emptyMap();
         }
         this.crdInfo = crdInfo;
         this.concurrentReconciliationThreads = maxThreads;
+        this.concurrentWorkflowExecutorThreads = maxWorflowThreads;
         this.terminationTimeout = timeout;
+        this.cacheSyncTimeout = cacheSyncTimeout;
         this.informerStoppedHandler = informerStoppedHandler;
         this.leaderElectionConfiguration = leaderElectionConfiguration;
     }
@@ -166,4 +178,24 @@ public Optional<LeaderElectionConfiguration> getLeaderElectionConfiguration() {
     public Optional<InformerStoppedHandler> getInformerStoppedHandler() {
         return Optional.ofNullable(informerStoppedHandler);
     }
+
+    @Override
+    public int concurrentWorkflowExecutorThreads() {
+        return concurrentWorkflowExecutorThreads;
+    }
+
+    @Override
+    public boolean closeClientOnStop() {
+        return closeClientOnStop;
+    }
+
+    @Override
+    public boolean stopOnInformerErrorDuringStartup() {
+        return stopOnInformerErrorDuringStartup;
+    }
+
+    @Override
+    public Duration cacheSyncTimeout() {
+        return cacheSyncTimeout;
+    }
 }

core/runtime/src/main/java/io/quarkiverse/operatorsdk/runtime/QuarkusControllerConfiguration.java

@@ -91,9 +91,7 @@ public DefaultRateLimiter(Duration refreshPeriod, int limitForPeriod) {
     private boolean namespaceExpansionRequired;
     @IgnoreProperty
     private List<DependentResourceSpec> dependentResources;
-
     private Retry retry;
-
     private RateLimiter rateLimiter;
 
     @RecordableConstructor

core/runtime/src/main/java/io/quarkiverse/operatorsdk/runtime/RunTimeOperatorConfiguration.java

@@ -14,6 +14,7 @@
  */
 package io.quarkiverse.operatorsdk.runtime;
 
+import java.time.Duration;
 import java.util.List;
 import java.util.Map;
 import java.util.Optional;
@@ -49,4 +50,17 @@ public class RunTimeOperatorConfiguration {
      */
     @ConfigItem
     public Optional<List<String>> namespaces;
+
+    /**
+     * The max number of concurrent workflow processing requests.
+     */
+    @ConfigItem
+    public Optional<Integer> concurrentWorkflowThreads;
+
+    /**
+     * How long the operator will wait for informers to finish synchronizing their caches on startup
+     * before timing out.
+     */
+    @ConfigItem(defaultValue = "2M")
+    public Duration cacheSyncTimeout;
 }

pom.xml

@@ -13,7 +13,7 @@
   <name>Quarkus - Operator SDK - Parent</name>
   <properties>
     <quarkus.version>2.14.1.Final</quarkus.version>
-    <java-operator-sdk.version>4.1.2</java-operator-sdk.version>
+    <java-operator-sdk.version>4.1.3-SNAPSHOT</java-operator-sdk.version>
   </properties>
 
   <repositories>