From ce030da360993cc512841a10c3942e0ccbbc64bc Mon Sep 17 00:00:00 2001 From: Svetlana Karslioglu Date: Thu, 25 Jan 2024 08:47:50 -0800 Subject: [PATCH 1/2] Update CONTRIBUTING.md Update managing data to ask users to put data download logic to download.py instead of Makefile. --- CONTRIBUTING.md | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index f6adf15d02b..b564a16e676 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -87,11 +87,10 @@ training data, or test data. We recommend storing this data in a commonly-used storage service, such as Amazon S3, and instructing your users to download the data at the beginning of your tutorial. -The -[Makefile](https://github.com/pytorch/tutorials/blob/main/Makefile) -that we use to build the tutorials contains automation that downloads -required data files. - +To download your data add a function to the [download.py](https://github.com/pytorch/tutorials/blob/main/.jenkins/download_data.py) +script. Follow the same patern as other download functions. +Please do not add download logic to Makefile since they will be +downloaded on all workers. # Python packages used by your tutorial From ed44b5e3a18413f03f24715f00514ff0c2255078 Mon Sep 17 00:00:00 2001 From: Svetlana Karslioglu Date: Fri, 26 Jan 2024 14:23:01 -0800 Subject: [PATCH 2/2] Update CONTRIBUTING.md --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index b564a16e676..daff325d9e6 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -88,7 +88,7 @@ commonly-used storage service, such as Amazon S3, and instructing your users to download the data at the beginning of your tutorial. To download your data add a function to the [download.py](https://github.com/pytorch/tutorials/blob/main/.jenkins/download_data.py) -script. Follow the same patern as other download functions. +script. Follow the same pattern as other download functions. Please do not add download logic to Makefile since they will be downloaded on all workers.