Skip to content

Benchmark Recipe #1176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 2, 2020
Merged

Benchmark Recipe #1176

merged 2 commits into from
Dec 2, 2020

Conversation

heitorschueroff
Copy link
Contributor

@heitorschueroff heitorschueroff commented Oct 7, 2020 •
edited
Loading

This PR adds a recipe for PyTorch benchmark module.

TODO

  • Fix output formatting

cc @robieta, @brianjo, @ngimel

@netlify
Copy link

netlify bot commented Oct 7, 2020

Deploy preview for pytorch-tutorials-preview ready!

Built with commit 4598009

https://deploy-preview-1176--pytorch-tutorials-preview.netlify.app

@netlify
Copy link

netlify bot commented Oct 7, 2020 •
edited
Loading

Deploy preview for pytorch-tutorials-preview ready!

Built with commit 35ad42e

https://deploy-preview-1176--pytorch-tutorials-preview.netlify.app

@heitorschueroff
Copy link
Contributor Author

@brianjo Is there a better way to display output from code besides putting it in a code block? Something like what you'd get from a python notebook?

@brianjo brianjo requested a review from ngimel October 12, 2020 19:10
ngimel
ngimel reviewed Oct 15, 2020
View reviewed changes
Copy link

@ngimel ngimel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tutorial feels like 2 in 1 - basic use of benchmarking tools, and how to optimize your custom op implementation. Many people to whom benchmarking tools are addressed don't write a single line of c++ in their daily lives, and yet would still benefit from knowing how to benchmark their code correctly. So it might make sense to either split it in 2, or structure it in such a way so that there's a first part for everyone, and second part for those who are still able to follow.
I didn't get to the end, but let me know if it makes sense.

@heitorschueroff heitorschueroff marked this pull request as draft October 21, 2020 14:12
@heitorschueroff heitorschueroff changed the title Benchmark Recipe [WIP] Benchmark Recipe Oct 21, 2020
@heitorschueroff heitorschueroff changed the title [WIP] Benchmark Recipe Benchmark Recipe Nov 10, 2020
@heitorschueroff heitorschueroff marked this pull request as ready for review November 10, 2020 20:48
@robieta robieta mentioned this pull request Nov 11, 2020
Closed
ngimel
ngimel approved these changes Nov 17, 2020
View reviewed changes
Copy link

@ngimel ngimel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python portion looks good now! C++ section could use some updating once latest improvements that avoid python altogether are landed.

@brianjo brianjo merged commit 8777ee2 into pytorch:master Dec 2, 2020
@heitorschueroff heitorschueroff deleted the benchmark branch December 2, 2020 20:54
rodrigo-techera pushed a commit to Experience-Monks/tutorials that referenced this pull request Nov 29, 2021
@heitorschueroff @brianjo
[WIP] Benchmark Recipe (pytorch#1176)
1efef1b 
Co-authored-by: Brian Johnson <brianjo@fb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngimel ngimel ngimel approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@heitorschueroff @ngimel @brianjo @facebook-github-bot