Skip to content

Commit 4e85999

Browse files
peterjc123soumith
authored andcommitted
Use cmake --build . instead of make (#733)
* Use `cmake --build .` instead of `make` * Minor fix * More fixes
1 parent a65bbe2 commit 4e85999

File tree

2 files changed

+9
-5
lines changed

2 files changed

+9
-5
lines changed

advanced_source/cpp_export.rst

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -228,6 +228,8 @@ structure:
228228
.. tip::
229229
On Windows, debug and release builds are not ABI-compatible. If you plan to
230230
build your project in debug mode, please try the debug version of LibTorch.
231+
Also, make sure you specify the correct configuration in the ``cmake --build .``
232+
line below.
231233

232234
The last step is building the application. For this, assume our example
233235
directory is laid out like this:
@@ -246,7 +248,7 @@ We can now run the following commands to build the application from within the
246248
mkdir build
247249
cd build
248250
cmake -DCMAKE_PREFIX_PATH=/path/to/libtorch ..
249-
make
251+
cmake --build . --config Release
250252
251253
where ``/path/to/libtorch`` should be the full path to the unzipped LibTorch
252254
distribution. If all goes well, it will look something like this:

advanced_source/cpp_frontend.rst

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -105,6 +105,8 @@ environment, however you are free to follow along on MacOS or Windows too.
105105
.. tip::
106106
On Windows, debug and release builds are not ABI-compatible. If you plan to
107107
build your project in debug mode, please try the debug version of LibTorch.
108+
Also, make sure you specify the correct configuration in the ``cmake --build .``
109+
line below.
108110

109111
The first step is to download the LibTorch distribution locally, via the link
110112
retrieved from the PyTorch website. For a vanilla Ubuntu Linux environment, this
@@ -201,17 +203,17 @@ corresponding absolute path. Now, we are ready to build our application:
201203
-- Configuring done
202204
-- Generating done
203205
-- Build files have been written to: /home/build
204-
root@fa350df05ecf:/home/build# make -j
206+
root@fa350df05ecf:/home/build# cmake --build . --config Release
205207
Scanning dependencies of target dcgan
206208
[ 50%] Building CXX object CMakeFiles/dcgan.dir/dcgan.cpp.o
207209
[100%] Linking CXX executable dcgan
208210
[100%] Built target dcgan
209211
210212
Above, we first created a ``build`` folder inside of our ``dcgan`` directory,
211213
entered this folder, ran the ``cmake`` command to generate the necessary build
212-
(Make) files and finally compiled the project successfully by running ``make
213-
-j``. We are now all set to execute our minimal binary and complete this section
214-
on basic project configuration:
214+
(Make) files and finally compiled the project successfully by running ``cmake
215+
--build . --config Release``. We are now all set to execute our minimal binary
216+
and complete this section on basic project configuration:
215217
216218
.. code-block:: shell
217219

0 commit comments

Comments
 (0)