@@ -27,20 +27,20 @@ and ``BackendConfig`` to specify the supported ways of quantization in their bac
27
27
This API covers most use cases relatively well, but the main problem is that this API is not fully extensible
28
28
without involvement of the quantization team:
29
29
30
- - Current API has limitation around expressing quantization intentions for complicated operator patterns such as in the discussion of
30
+ - This API has limitation around expressing quantization intentions for complicated operator patterns such as in the discussion of
31
31
`Issue-96288 <https://github.com/pytorch/pytorch/issues/96288 >`__ to support ``conv add `` fusion.
32
32
Supporting ``conv add `` fusion also requires some changes to current already complicated pattern matching code such as in the
33
33
`PR-97122 <https://github.com/pytorch/pytorch/pull/97122 >`__.
34
- - Current API also has limitation around supporting user's advanced quantization intention to quantize their model. For example, if backend
34
+ - This API also has limitation around supporting user's advanced quantization intention to quantize their model. For example, if backend
35
35
developer only wants to quantize inputs and outputs when the ``linear `` has a third input, it requires co-work from quantization
36
36
team and backend developer.
37
- - Current API uses ``QConfigMapping `` and ``BackendConfig `` as separate object. ``QConfigMapping `` describes user's
37
+ - This API uses ``QConfigMapping `` and ``BackendConfig `` as separate object. ``QConfigMapping `` describes user's
38
38
intention of how they want their model to be quantized. ``BackendConfig `` describes what kind of quantization a backend support.
39
- Currently, ``BackendConfig `` is backend specific, but ``QConfigMapping `` is not. And user can provide a ``QConfigMapping ``
39
+ ``BackendConfig `` is backend specific, but ``QConfigMapping `` is not. And user can provide a ``QConfigMapping ``
40
40
that is incompatible with a specific ``BackendConfig ``. This is not a great UX. Ideally, we can structure this better
41
41
by making both configuration (``QConfigMapping ``) and quantization capability (``BackendConfig ``) backend
42
42
specific. So there will be less confusion about incompatibilities.
43
- - Currently, in ``QConfig `` we are exposing observer/fake_quant classes as an object for user to configure quantization.
43
+ - In ``QConfig ``, we are exposing observer/fake_quant classes as an object for user to configure quantization.
44
44
This increases the things that user needs to care about, e.g. not only the ``dtype `` but also how the
45
45
observation should happen. These could potentially be hidden from user to make user interface simpler.
46
46
0 commit comments