Skip to content

Commit 17b14ca

Browse files
fix self.init_hidden never used
1 parent 0c284e9 commit 17b14ca

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

beginner_source/nlp/advanced_tutorial.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -180,8 +180,8 @@ def __init__(self, vocab_size, tag_to_ix, embedding_dim, hidden_dim):
180180
self.hidden = self.init_hidden()
181181

182182
def init_hidden(self):
183-
return (autograd.Variable(torch.randn(2, 1, self.hidden_dim)),
184-
autograd.Variable(torch.randn(2, 1, self.hidden_dim)))
183+
return (autograd.Variable(torch.randn(2, 1, self.hidden_dim / 2)),
184+
autograd.Variable(torch.randn(2, 1, self.hidden_dim / 2)))
185185

186186
def _forward_alg(self, feats):
187187
# Do the forward algorithm to compute the partition function
@@ -217,7 +217,7 @@ def _forward_alg(self, feats):
217217
def _get_lstm_features(self, sentence):
218218
self.hidden = self.init_hidden()
219219
embeds = self.word_embeds(sentence).view(len(sentence), 1, -1)
220-
lstm_out, self.hidden = self.lstm(embeds)
220+
lstm_out, self.hidden = self.lstm(embeds, self.hidden)
221221
lstm_out = lstm_out.view(len(sentence), self.hidden_dim)
222222
lstm_feats = self.hidden2tag(lstm_out)
223223
return lstm_feats

0 commit comments

Comments
 (0)