Revert "Reenable optimizer overlap tests (#88439)"

This reverts commit da452bc.

Reverted #88439 on behalf of https://github.com/huydhn due to This change breaks trunk due to a land race missing reason parameter to sandcastle_skip_if https://hud.pytorch.org/pytorch/pytorch/commit/da452bcadbc6f34989c6b3b0db6075a272aa9891

Author: pytorchmergebot

torch/testing/_internal/distributed/distributed_test.py

@@ -4494,7 +4494,8 @@ def _test_ddp_hook_with_optimizer_parity(
                     dist.barrier()
 
         @sandcastle_skip_if(
-            BACKEND == "ucc",
+            BACKEND == "nccl" or BACKEND == "ucc",
+            "Issues with async error handling, see https://github.com/pytorch/pytorch/issues/73259"
         )
         @skip_if_lt_x_gpu(2)
         @parametrize("grad_as_bucket_view", [True, False])
@@ -4520,7 +4521,8 @@ def test_ddp_hook_with_optimizer_parity_adamw(
             )
 
         @sandcastle_skip_if(
-            BACKEND == "ucc",
+            BACKEND == "nccl" or BACKEND == "ucc",
+            "Issues with async error handling, see https://github.com/pytorch/pytorch/issues/73259"
         )
         @skip_if_lt_x_gpu(2)
         @parametrize("optimize_subset", [True, False])
@@ -4539,7 +4541,8 @@ def test_ddp_hook_with_optimizer_parity_adam(self, optimize_subset):
             )
 
         @sandcastle_skip_if(
-            BACKEND == "ucc",
+            BACKEND == "nccl" or BACKEND == "ucc",
+            "Issues with async error handling, see https://github.com/pytorch/pytorch/issues/73259"
         )
         @skip_if_lt_x_gpu(2)
         @parametrize("optimize_subset", [True, False])