Skip to content

Commit 9f67b51

Browse files
authored
[TorchFix] Fix bug in TorchVisionDeprecatedToTensorVisitor with ImportStar (#4641)
Incrementing patch version as 0.1.0 already pushed to PyPI.
1 parent 092ff3f commit 9f67b51

File tree

3 files changed

+11
-6
lines changed

3 files changed

+11
-6
lines changed

tests/fixtures/vision/checker/to_tensor.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,3 +24,5 @@
2424
import torchvision.transforms.v2
2525

2626
torchvision.transforms.v2.ToTensor
27+
28+
from torchvision.transforms.v2 import *

torchfix/torchfix.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,11 @@
1313
from .visitors.performance import TorchSynchronizedDataLoaderVisitor
1414
from .visitors.misc import TorchRequireGradVisitor
1515
from .visitors.vision import (
16-
TorchVisionDeprecatedPretrainedVisitor, TorchVisionDeprecatedToTensorVisitor
16+
TorchVisionDeprecatedPretrainedVisitor,
17+
TorchVisionDeprecatedToTensorVisitor,
1718
)
1819

19-
__version__ = "0.1.0"
20+
__version__ = "0.1.1"
2021

2122
DEPRECATED_CONFIG_PATH = Path(__file__).absolute().parent / "deprecated_symbols.yaml"
2223

torchfix/visitors/vision/to_tensor.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
from collections.abc import Sequence
12
import libcst as cst
23

34
from ...common import LintViolation, TorchVisitor
@@ -34,10 +35,11 @@ def visit_ImportFrom(self, node):
3435
if module_path is None:
3536
return
3637

37-
for import_node in node.names:
38-
self._maybe_add_violation(
39-
f"{module_path}.{import_node.evaluated_name}", import_node
40-
)
38+
if isinstance(node.names, Sequence):
39+
for import_node in node.names:
40+
self._maybe_add_violation(
41+
f"{module_path}.{import_node.evaluated_name}", import_node
42+
)
4143

4244
def visit_Attribute(self, node):
4345
qualified_names = self.get_metadata(cst.metadata.QualifiedNameProvider, node)

0 commit comments

Comments
 (0)