From e880c6e4bb3a95df32cd7a35e2315f2ac99e9c64 Mon Sep 17 00:00:00 2001 From: Sam Gross Date: Fri, 14 Feb 2025 19:02:05 +0000 Subject: [PATCH] gh-130095: Mark _py_abc tests as not thread-safe The `_py_abc` implementation is not currently thread-safe (even with the GIL). Don't run these tests with `--parallel-threads=N` for now. --- Lib/test/test_abc.py | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/Lib/test/test_abc.py b/Lib/test/test_abc.py index e90a8dc617c094..80ee9e0ba56e75 100644 --- a/Lib/test/test_abc.py +++ b/Lib/test/test_abc.py @@ -684,10 +684,16 @@ class B(A, metaclass=abc_ABCMeta, name="test"): return TestLegacyAPI, TestABC, TestABCWithInitSubclass -TestLegacyAPI_Py, TestABC_Py, TestABCWithInitSubclass_Py = test_factory(abc.ABCMeta, - abc.get_cache_token) -TestLegacyAPI_C, TestABC_C, TestABCWithInitSubclass_C = test_factory(_py_abc.ABCMeta, - _py_abc.get_cache_token) +TestLegacyAPI_Py, TestABC_Py, TestABCWithInitSubclass_Py = test_factory(_py_abc.ABCMeta, + _py_abc.get_cache_token) +TestLegacyAPI_C, TestABC_C, TestABCWithInitSubclass_C = test_factory(abc.ABCMeta, + abc.get_cache_token) + +# gh-130095: The _py_abc tests are not thread-safe when run with +# `--parallel-threads` +TestLegacyAPI_Py.__unittest_thread_unsafe__ = True +TestABC_Py.__unittest_thread_unsafe__ = True +TestABCWithInitSubclass_Py.__unittest_thread_unsafe__ = True if __name__ == "__main__": unittest.main()