Skip to content

Correct 416 status code enum name #11689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2019
Merged

Correct 416 status code enum name #11689

merged 1 commit into from
Jan 31, 2019

Conversation

pgjones
Copy link
Contributor

@pgjones pgjones commented Jan 28, 2019

See Lib/http/__init__.py#L97, it is REQUESTED_RANGE_NOT_SATISFIABLE
rather than REQUEST_RANGE_NOT_SATISFIABLE.

I think this is a trivial change that doesn't need an issue (Trivial changes, like fixing a typo, do not need an issue.).

See Lib/http/__init__.py#L97, it is `REQUESTED_RANGE_NOT_SATISFIABLE` 
rather than `REQUEST_RANGE_NOT_SATISFIABLE`.
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Jan 28, 2019
Copy link
Contributor

@eamanu eamanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that is reasonable fix. You Must sign CLA, first.

@pgjones
Copy link
Contributor Author

pgjones commented Jan 28, 2019

I've just signed it - does it take a while to propagate?

@eamanu
Copy link
Contributor

eamanu commented Jan 28, 2019

I've signed it - just it take a while to propagate?

Yes

@eamanu
Copy link
Contributor

eamanu commented Jan 30, 2019

Hi @pgjones if you don't receive feedback by some core dev in a couple of day, please open a issue on bpo.

@methane methane added type-bug An unexpected behavior, bug, or error skip issue skip news needs backport to 3.7 labels Jan 31, 2019
@methane methane merged commit d97daeb into python:master Jan 31, 2019
@miss-islington
Copy link
Contributor

Thanks @pgjones for the PR, and @methane for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@methane
Copy link
Member

methane commented Jan 31, 2019

thanks

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 31, 2019
(cherry picked from commit d97daeb)

Co-authored-by: Phil Jones <philip.graham.jones@googlemail.com>
@bedevere-bot
Copy link

GH-11713 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Jan 31, 2019
(cherry picked from commit d97daeb)

Co-authored-by: Phil Jones <philip.graham.jones@googlemail.com>
@pgjones
Copy link
Contributor Author

pgjones commented Jan 31, 2019

Thank you.

@eamanu
Copy link
Contributor

eamanu commented Jan 31, 2019

@pgjones has been added to ACK, @methane?

@methane
Copy link
Member

methane commented Feb 1, 2019

@eamanu Good question. I forgot about Misc/ACKS.
I confirmed about it. https://devguide.python.org/pullrequest/#crediting

So trivial change which doesn't require NEWs entry, doesn't require ACKS entry too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants