-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
Correct 416 status code enum name #11689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
See Lib/http/__init__.py#L97, it is `REQUESTED_RANGE_NOT_SATISFIABLE` rather than `REQUEST_RANGE_NOT_SATISFIABLE`.
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for your contribution, we look forward to reviewing it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that is reasonable fix. You Must sign CLA, first.
I've just signed it - does it take a while to propagate? |
Yes |
Hi @pgjones if you don't receive feedback by some core dev in a couple of day, please open a issue on bpo. |
thanks |
(cherry picked from commit d97daeb) Co-authored-by: Phil Jones <philip.graham.jones@googlemail.com>
GH-11713 is a backport of this pull request to the 3.7 branch. |
(cherry picked from commit d97daeb) Co-authored-by: Phil Jones <philip.graham.jones@googlemail.com>
Thank you. |
@eamanu Good question. I forgot about So trivial change which doesn't require NEWs entry, doesn't require ACKS entry too. |
See
Lib/http/__init__.py#L97
, it isREQUESTED_RANGE_NOT_SATISFIABLE
rather than
REQUEST_RANGE_NOT_SATISFIABLE
.I think this is a trivial change that doesn't need an issue (
Trivial changes, like fixing a typo, do not need an issue.
).