Skip to content

Commit 2a09611

Browse files
Alan HuangAlan Huang
Alan Huang
authored and
Alan Huang
committed
bpo-34001: add test for protocol boundary restrictions
This commit adds tests for the new {min,max}imum_version restrictions. Attempting to set an invalid range should ValueError, and the value should not be changed after the attempt.
1 parent 77d24d8 commit 2a09611

File tree

1 file changed

+17
-0
lines changed

1 file changed

+17
-0
lines changed

Lib/test/test_ssl.py

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1105,6 +1105,23 @@ def test_min_max_version(self):
11051105
{ssl.TLSVersion.TLSv1_2, ssl.TLSVersion.TLSv1_3}
11061106
)
11071107

1108+
with self.assertRaises(ValueError):
1109+
ctx.maximum_version = ssl.TLSVersion.MINIMUM_SUPPORTED
1110+
1111+
self.assertEqual(
1112+
ctx.maximum_version, ssl.TLSVersion.MAXIMUM_SUPPORTED
1113+
)
1114+
1115+
ctx.minimum_version = ssl.TLSVersion.MINIMUM_SUPPORTED
1116+
ctx.maximum_version = ssl.TLSVersion.MINIMUM_SUPPORTED
1117+
1118+
with self.assertRaises(ValueError):
1119+
ctx.minimum_version = ssl.TLSVersion.MAXIMUM_SUPPORTED
1120+
1121+
self.assertEqual(
1122+
ctx.minimum_version, ssl.TLSVersion.MINIMUM_SUPPORTED
1123+
)
1124+
11081125
with self.assertRaises(ValueError):
11091126
ctx.minimum_version = 42
11101127

0 commit comments

Comments
 (0)