From e5f891e665d407917c00cb4b793ec17b66c22596 Mon Sep 17 00:00:00 2001 From: Carlos Cordoba Date: Mon, 31 Oct 2022 10:27:52 -0500 Subject: [PATCH] Don't include class objects by default in completions Also update config files to reflect this change and the one in PR 274 --- CONFIGURATION.md | 4 ++-- pylsp/config/schema.json | 4 ++-- pylsp/plugins/jedi_completion.py | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/CONFIGURATION.md b/CONFIGURATION.md index f0c3e1b5..61d500bd 100644 --- a/CONFIGURATION.md +++ b/CONFIGURATION.md @@ -21,8 +21,8 @@ This server can be configured using the `workspace/didChangeConfiguration` metho | `pylsp.plugins.jedi.environment` | `string` | Define environment for jedi.Script and Jedi.names. | `null` | | `pylsp.plugins.jedi_completion.enabled` | `boolean` | Enable or disable the plugin. | `true` | | `pylsp.plugins.jedi_completion.include_params` | `boolean` | Auto-completes methods and classes with tabstops for each parameter. | `true` | -| `pylsp.plugins.jedi_completion.include_class_objects` | `boolean` | Adds class objects as a separate completion item. | `true` | -| `pylsp.plugins.jedi_completion.include_function_objects` | `boolean` | Adds function objects as a separate completion item. | `true` | +| `pylsp.plugins.jedi_completion.include_class_objects` | `boolean` | Adds class objects as a separate completion item. | `false` | +| `pylsp.plugins.jedi_completion.include_function_objects` | `boolean` | Adds function objects as a separate completion item. | `false` | | `pylsp.plugins.jedi_completion.fuzzy` | `boolean` | Enable fuzzy when requesting autocomplete. | `false` | | `pylsp.plugins.jedi_completion.eager` | `boolean` | Resolve documentation and detail eagerly. | `false` | | `pylsp.plugins.jedi_completion.resolve_at_most` | `integer` | How many labels and snippets (at most) should be resolved? | `25` | diff --git a/pylsp/config/schema.json b/pylsp/config/schema.json index bb82145f..ee27b63e 100644 --- a/pylsp/config/schema.json +++ b/pylsp/config/schema.json @@ -117,12 +117,12 @@ }, "pylsp.plugins.jedi_completion.include_class_objects": { "type": "boolean", - "default": true, + "default": false, "description": "Adds class objects as a separate completion item." }, "pylsp.plugins.jedi_completion.include_function_objects": { "type": "boolean", - "default": true, + "default": false, "description": "Adds function objects as a separate completion item." }, "pylsp.plugins.jedi_completion.fuzzy": { diff --git a/pylsp/plugins/jedi_completion.py b/pylsp/plugins/jedi_completion.py index e7738148..4c79ebf5 100644 --- a/pylsp/plugins/jedi_completion.py +++ b/pylsp/plugins/jedi_completion.py @@ -56,7 +56,7 @@ def pylsp_completions(config, document, position): preferred_markup_kind = _utils.choose_markup_kind(supported_markup_kinds) should_include_params = settings.get('include_params') - should_include_class_objects = settings.get('include_class_objects', True) + should_include_class_objects = settings.get('include_class_objects', False) should_include_function_objects = settings.get('include_function_objects', False) max_to_resolve = settings.get('resolve_at_most', 25)