Skip to content

Commit de937ea

Browse files
authored
Don't include class objects by default in completions (#285)
Also update config files to reflect this change and the one in PR 274
1 parent 7e8fc6c commit de937ea

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

CONFIGURATION.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@ This server can be configured using the `workspace/didChangeConfiguration` metho
2121
| `pylsp.plugins.jedi.environment` | `string` | Define environment for jedi.Script and Jedi.names. | `null` |
2222
| `pylsp.plugins.jedi_completion.enabled` | `boolean` | Enable or disable the plugin. | `true` |
2323
| `pylsp.plugins.jedi_completion.include_params` | `boolean` | Auto-completes methods and classes with tabstops for each parameter. | `true` |
24-
| `pylsp.plugins.jedi_completion.include_class_objects` | `boolean` | Adds class objects as a separate completion item. | `true` |
25-
| `pylsp.plugins.jedi_completion.include_function_objects` | `boolean` | Adds function objects as a separate completion item. | `true` |
24+
| `pylsp.plugins.jedi_completion.include_class_objects` | `boolean` | Adds class objects as a separate completion item. | `false` |
25+
| `pylsp.plugins.jedi_completion.include_function_objects` | `boolean` | Adds function objects as a separate completion item. | `false` |
2626
| `pylsp.plugins.jedi_completion.fuzzy` | `boolean` | Enable fuzzy when requesting autocomplete. | `false` |
2727
| `pylsp.plugins.jedi_completion.eager` | `boolean` | Resolve documentation and detail eagerly. | `false` |
2828
| `pylsp.plugins.jedi_completion.resolve_at_most` | `integer` | How many labels and snippets (at most) should be resolved? | `25` |

pylsp/config/schema.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -117,12 +117,12 @@
117117
},
118118
"pylsp.plugins.jedi_completion.include_class_objects": {
119119
"type": "boolean",
120-
"default": true,
120+
"default": false,
121121
"description": "Adds class objects as a separate completion item."
122122
},
123123
"pylsp.plugins.jedi_completion.include_function_objects": {
124124
"type": "boolean",
125-
"default": true,
125+
"default": false,
126126
"description": "Adds function objects as a separate completion item."
127127
},
128128
"pylsp.plugins.jedi_completion.fuzzy": {

pylsp/plugins/jedi_completion.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ def pylsp_completions(config, document, position):
5656
preferred_markup_kind = _utils.choose_markup_kind(supported_markup_kinds)
5757

5858
should_include_params = settings.get('include_params')
59-
should_include_class_objects = settings.get('include_class_objects', True)
59+
should_include_class_objects = settings.get('include_class_objects', False)
6060
should_include_function_objects = settings.get('include_function_objects', False)
6161

6262
max_to_resolve = settings.get('resolve_at_most', 25)

0 commit comments

Comments
 (0)