Skip to content

Commit c778ee7

Browse files
authored
Fix deployment workflow (#358)
* Set SETUPTOOLS_SCM_PRETEND_VERSION so we build the package with the correct version. * Update gh-action-pypi-publish to latest version * Update RELEASING with new instructions
1 parent 5068287 commit c778ee7

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

.github/workflows/deploy.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@ jobs:
1515
environment: deploy
1616
permissions:
1717
id-token: write # For PyPI trusted publishers.
18+
env:
19+
SETUPTOOLS_SCM_PRETEND_VERSION: ${{ github.event.inputs.version }}
1820

1921
steps:
2022
- uses: actions/checkout@v3
@@ -29,7 +31,7 @@ jobs:
2931
path: dist
3032

3133
- name: Publish package to PyPI
32-
uses: pypa/gh-action-pypi-publish@master
34+
uses: pypa/gh-action-pypi-publish@v1.8.5
3335

3436
- uses: actions-ecosystem/action-push-tag@v1
3537
with:

RELEASING.rst

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
Here are the steps on how to make a new release.
22

3-
1. Create a ``release-VERSION`` branch from ``upstream/master``.
3+
1. Create a ``release-VERSION`` branch from ``upstream/main``.
44
2. Update ``CHANGELOG.rst``.
5-
3. Push a branch with the changes.
6-
4. Once all builds pass, run the ``deploy`` workflow manually.
5+
3. Push the branch to ``upstream``.
6+
4. Once all tests pass, start the ``deploy`` workflow manually.
77
5. Merge the PR.

0 commit comments

Comments
 (0)