Skip to content

Commit ee878c2

Browse files
authored
Remove pytest_compat now that the requirement is 3.6+ (#616)
1 parent 032e060 commit ee878c2

File tree

4 files changed

+9
-17
lines changed

4 files changed

+9
-17
lines changed

pytest_django/fixtures.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
from . import live_server_helper
1212

1313
from .django_compat import is_django_unittest
14-
from .pytest_compat import getfixturevalue
1514

1615
from .lazy_django import skip_if_no_django
1716

@@ -155,7 +154,7 @@ def db(request, django_db_setup, django_db_blocker):
155154
"""
156155
if 'transactional_db' in request.funcargnames \
157156
or 'live_server' in request.funcargnames:
158-
getfixturevalue(request, 'transactional_db')
157+
request.getfixturevalue('transactional_db')
159158
else:
160159
_django_db_fixture_helper(False, request, django_db_blocker)
161160

@@ -346,9 +345,9 @@ def _live_server_helper(request):
346345
if 'live_server' not in request.funcargnames:
347346
return
348347

349-
getfixturevalue(request, 'transactional_db')
348+
request.getfixturevalue('transactional_db')
350349

351-
live_server = getfixturevalue(request, 'live_server')
350+
live_server = request.getfixturevalue('live_server')
352351
live_server._live_server_modified_settings.enable()
353352
request.addfinalizer(live_server._live_server_modified_settings.disable)
354353

pytest_django/plugin.py

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@
3333
from .fixtures import rf # noqa
3434
from .fixtures import settings # noqa
3535
from .fixtures import transactional_db # noqa
36-
from .pytest_compat import getfixturevalue
3736

3837
from .lazy_django import django_settings_is_configured, skip_if_no_django
3938

@@ -386,17 +385,17 @@ def _django_db_marker(request):
386385
if marker:
387386
transaction = validate_django_db(marker)
388387
if transaction:
389-
getfixturevalue(request, 'transactional_db')
388+
request.getfixturevalue('transactional_db')
390389
else:
391-
getfixturevalue(request, 'db')
390+
request.getfixturevalue('db')
392391

393392

394393
@pytest.fixture(autouse=True, scope='class')
395394
def _django_setup_unittest(request, django_db_blocker):
396395
"""Setup a django unittest, internal to pytest-django."""
397396
if django_settings_is_configured() and is_django_unittest(request):
398-
getfixturevalue(request, 'django_test_environment')
399-
getfixturevalue(request, 'django_db_setup')
397+
request.getfixturevalue('django_test_environment')
398+
request.getfixturevalue('django_db_setup')
400399

401400
django_db_blocker.unblock()
402401

pytest_django/pytest_compat.py

Lines changed: 0 additions & 5 deletions
This file was deleted.

tests/test_database.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
from django.db import connection
55
from django.test.testcases import connections_support_transactions
66

7-
from pytest_django.pytest_compat import getfixturevalue
87
from pytest_django_test.app.models import Item
98

109

@@ -34,9 +33,9 @@ class TestDatabaseFixtures:
3433
@pytest.fixture(params=['db', 'transactional_db'])
3534
def both_dbs(self, request):
3635
if request.param == 'transactional_db':
37-
return getfixturevalue(request, 'transactional_db')
36+
return request.getfixturevalue('transactional_db')
3837
elif request.param == 'db':
39-
return getfixturevalue(request, 'db')
38+
return request.getfixturevalue('db')
4039

4140
def test_access(self, both_dbs):
4241
Item.objects.create(name='spam')

0 commit comments

Comments
 (0)