Skip to content

Commit 8433d5b

Browse files
committed
Always set reset_sequences on the test class according to the given value
This way Django will warn about any misuses and we don't rely on defaults.
1 parent 3a7ed7a commit 8433d5b

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

pytest_django/fixtures.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -178,8 +178,7 @@ def _django_db_helper(
178178
_databases = databases
179179

180180
class PytestDjangoTestCase(test_case_class): # type: ignore[misc,valid-type]
181-
if transactional and _reset_sequences:
182-
reset_sequences = True
181+
reset_sequences = _reset_sequences
183182
if _databases is not None:
184183
databases = _databases
185184

tests/test_database.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -219,7 +219,7 @@ def test_reset_sequences_disabled(self, request) -> None:
219219
marker = request.node.get_closest_marker("django_db")
220220
assert not marker.kwargs
221221

222-
@pytest.mark.django_db(reset_sequences=True)
222+
@pytest.mark.django_db(transaction=True, reset_sequences=True)
223223
def test_reset_sequences_enabled(self, request) -> None:
224224
marker = request.node.get_closest_marker("django_db")
225225
assert marker.kwargs["reset_sequences"]

0 commit comments

Comments
 (0)