Types

Author: FabioRosado

src/psc/fixtures.py

@@ -4,6 +4,7 @@
 import builtins
 from collections.abc import Callable
 from collections.abc import Generator
+from collections.abc import Iterable
 from dataclasses import dataclass
 from dataclasses import field
 from mimetypes import guess_type
@@ -192,7 +193,7 @@ class FakeDocument:
 
 
 @pytest.fixture
-def fake_document() -> FakeDocument:
+def fake_document() -> Iterable[FakeDocument]:
     """Yield a document that cleans up."""
     yield FakeDocument()
 
@@ -208,7 +209,7 @@ def write(self, value: str) -> None:
         """Collect anything that is written to the node."""
         self.document.log.append(value)
 
-    def removeAttribute(self, name) -> None:  # noqa
+    def removeAttribute(self, name: str) -> None:  # noqa
         """Pretend to remove an attribute from this node."""
         pass
 
@@ -227,10 +228,10 @@ def __call__(self, key: str) -> ElementNode:
 
 
 @pytest.fixture
-def fake_element(fake_document) -> None:
+def fake_element(fake_document: FakeDocument) -> None: # type: ignore [misc]
     """Install the stateful Element into builtins."""
     try:
-        builtins.Element = ElementCallable(fake_document)
+        builtins.Element = ElementCallable(fake_document) #type: ignore [attr-defined]
         yield
     finally:
         delattr(builtins, "Element")

src/psc/gallery/examples/hello_world_py/hello_world.py

@@ -1,3 +1,3 @@
 """Say Hello."""
-output = Element("output")
+output = Element("output") #type: ignore
 output.write("From Python...")

tests/test_fixtures.py

@@ -11,13 +11,16 @@
 from psc.fixtures import DummyRequest
 from psc.fixtures import DummyResponse
 from psc.fixtures import DummyRoute
+from psc.fixtures import FakeDocument
 from psc.fixtures import MockTestClient
 from psc.fixtures import PageT
 from psc.fixtures import mocked_client_page
 from psc.fixtures import route_handler
 from psc.here import STATIC
 
 
+Element = cast("Unknown", "Element")
+
 def test_test_client(test_client: TestClient) -> None:
     """Ensure fixture returns an initialized TestClient."""
     assert test_client.app
@@ -138,32 +141,32 @@ def test_route_handler_fake_bad_path() -> None:
 def test_fake_element_not_installed() -> None:
     """We don't request the fixture so it isn't available."""
     with pytest.raises(NameError):
-        Element  # noqa
+        Element # noqa
 
 
-def test_fake_element_installed(fake_element) -> None:
+def test_fake_element_installed(fake_element: function) -> None:
     """Element is available as ``fake_element`` installed it."""
-    Element  # noqa
+    Element # noqa
 
 
-def test_fake_element_find_element(fake_document, fake_element) -> None:
+def test_fake_element_find_element(fake_document: FakeDocument, fake_element: function) -> None:
     """The Element can get a value from the fake document."""
     fake_document.values["btn1"] = "value1"
     button = Element("btn1")  # noqa
     assert button.value == "value1"
 
 
-def test_fake_element_write(fake_document, fake_element) -> None:
+def test_fake_element_write(fake_document: FakeDocument, fake_element: function) -> None: 
     """The Element can write a value that is captured."""
     fake_document.values["btn1"] = "value1"
-    button = Element("btn1")  # noqa
+    button = Element("btn1") # noqa
     button.write("Some Value")
     assert fake_document.log[0] == "Some Value"
 
 
-def test_fake_element_remove_attribute(fake_document, fake_element) -> None:
+def test_fake_element_remove_attribute(fake_document: FakeDocument, fake_element: function) -> None:
     """The Element can pretend to remove an attribute."""
     fake_document.values["btn1"] = "value1"
-    button = Element("btn1")  # noqa
+    button = Element("btn1") # noqa
     button.removeAttribute("disabled")
     assert fake_document.log == []