Skip to content

Commit 90638fa

Browse files
Add Firefox for testing (#62)
* Add Firefox for testing * Remove xfail marker from `test_draw_math_text` because it passes now.
1 parent cb42e35 commit 90638fa

File tree

2 files changed

+7
-9
lines changed

2 files changed

+7
-9
lines changed

.github/workflows/main.yml

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ permissions:
99
contents: read
1010

1111
concurrency:
12-
group: main-${{ github.head_ref || github.run_id }}
12+
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
1313
cancel-in-progress: true
1414

1515
jobs:
@@ -22,10 +22,12 @@ jobs:
2222
matrix:
2323
os: [ubuntu-latest]
2424
pyodide-version: [0.26.4]
25-
test-config: [
26-
# FIXME: timeouts on recent versions of Chrome, same as micropip
27-
{runner: selenium, runtime: chrome, runtime-version: 125},
28-
]
25+
test-config:
26+
[
27+
# FIXME: timeouts on recent versions of Chrome, same as micropip
28+
{ runner: selenium, runtime: chrome, runtime-version: 125 },
29+
{ runner: selenium, runtime: firefox, runtime-version: latest },
30+
]
2931

3032
steps:
3133
- uses: actions/checkout@v4

tests/test_html5_canvas_backend.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import base64
22
import pathlib
33

4-
import pytest
54
from conftest import matplotlib_test_decorator
65
from pytest_pyodide import run_in_pyodide
76

@@ -277,9 +276,6 @@ def run(selenium, handle, ref):
277276

278277

279278
@matplotlib_test_decorator
280-
@pytest.mark.xfail(
281-
reason="TODO: pytest_pyodide.pyodide.JsException: InvalidStateError: An attempt was made to use an object that is not, or is no longer, usable"
282-
)
283279
def test_draw_math_text(selenium_standalone_matplotlib):
284280
selenium = selenium_standalone_matplotlib
285281

0 commit comments

Comments
 (0)