Skip to content

Commit 47e053a

Browse files
committed
XFAIL conv tests of Ops without Python implementation
Mark overly specific tests as xfail
1 parent b8d91b2 commit 47e053a

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

tests/tensor/conv/test_abstract_conv.py

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -948,9 +948,9 @@ def run_gradinput(
948948
)
949949

950950

951-
@pytest.mark.skipif(
952-
config.cxx == "",
953-
reason="SciPy and cxx needed",
951+
@pytest.mark.skipif(config.cxx == "", reason="cxx needed")
952+
@pytest.mark.xfail(
953+
reason="Involves Ops with no Python implementation for numba to use as fallback"
954954
)
955955
class TestAbstractConvNoOptim(BaseTestConv2d):
956956
@classmethod
@@ -1884,9 +1884,9 @@ def test_conv2d_grad_wrt_weights(self):
18841884
)
18851885

18861886

1887-
@pytest.mark.skipif(
1888-
config.cxx == "",
1889-
reason="SciPy and cxx needed",
1887+
@pytest.mark.skipif(config.cxx == "", reason="cxx needed")
1888+
@pytest.mark.xfail(
1889+
reason="Involves Ops with no Python implementation for numba to use as fallback"
18901890
)
18911891
class TestGroupedConvNoOptim:
18921892
conv = abstract_conv.AbstractConv2d
@@ -2096,9 +2096,9 @@ def conv_gradinputs(filters_val, output_val):
20962096
utt.verify_grad(conv_gradinputs, [kern, top], mode=self.mode, eps=1)
20972097

20982098

2099-
@pytest.mark.skipif(
2100-
config.cxx == "",
2101-
reason="SciPy and cxx needed",
2099+
@pytest.mark.skipif(config.cxx == "", reason="cxx needed")
2100+
@pytest.mark.xfail(
2101+
reason="Involves Ops with no Python implementation for numba to use as fallback"
21022102
)
21032103
class TestGroupedConv3dNoOptim(TestGroupedConvNoOptim):
21042104
conv = abstract_conv.AbstractConv3d

0 commit comments

Comments
 (0)