Cleanup Rop tests and fix Max Rop implementation

ricardoV94 · ricardoV94 · commit 3f00f46fc779 · 2025-02-14T18:52:51.000+01:00
diff --git a/tests/test_rop.py b/tests/test_rop.py
@@ -351,7 +351,7 @@ def test_Rop_partially_differentiable_paths(self):
             disconnected_outputs="raise",
         )
 
-        # More extensive testing shows that the legacy Rop implementation FAILS to raise when
+        # More extensive testing shows that the Rop implementation FAILS to raise when
         # the cost is linked through strictly non-differentiable paths.
         # This is not Dot specific, we would observe the same with any operation where the gradient
         # with respect to one of the inputs does not depend on the original input (such as `mul`, `add`, ...)

Original file line number	Diff line number	Diff line change
`@@ -351,7 +351,7 @@ def test_Rop_partially_differentiable_paths(self):`
`351`	`351`	`disconnected_outputs="raise",`
`352`	`352`	`)`
`353`	`353`
`354`		`- # More extensive testing shows that the legacy Rop implementation FAILS to raise when`
	`354`	`+ # More extensive testing shows that the Rop implementation FAILS to raise when`
`355`	`355`	`# the cost is linked through strictly non-differentiable paths.`
`356`	`356`	`# This is not Dot specific, we would observe the same with any operation where the gradient`
`357`	`357`	# with respect to one of the inputs does not depend on the original input (such as `mul`, `add`, ...)