Skip to content

Commit 3c3f75c

Browse files
committed
XFAIL conv tests of Ops without Python implementation
Mark overly specific tests as xfail
1 parent 0e72607 commit 3c3f75c

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

tests/tensor/conv/test_abstract_conv.py

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -946,9 +946,9 @@ def run_gradinput(
946946
)
947947

948948

949-
@pytest.mark.skipif(
950-
config.cxx == "",
951-
reason="SciPy and cxx needed",
949+
@pytest.mark.skipif(config.cxx == "", reason="cxx needed")
950+
@pytest.mark.xfail(
951+
reason="Involves Ops with no Python implementation for numba to use as fallback"
952952
)
953953
class TestAbstractConvNoOptim(BaseTestConv2d):
954954
@classmethod
@@ -1878,9 +1878,9 @@ def test_conv2d_grad_wrt_weights(self):
18781878
)
18791879

18801880

1881-
@pytest.mark.skipif(
1882-
config.cxx == "",
1883-
reason="SciPy and cxx needed",
1881+
@pytest.mark.skipif(config.cxx == "", reason="cxx needed")
1882+
@pytest.mark.xfail(
1883+
reason="Involves Ops with no Python implementation for numba to use as fallback"
18841884
)
18851885
class TestGroupedConvNoOptim:
18861886
conv = abstract_conv.AbstractConv2d
@@ -2082,9 +2082,9 @@ def conv_gradinputs(filters_val, output_val):
20822082
utt.verify_grad(conv_gradinputs, [kern, top], mode=self.mode, eps=1)
20832083

20842084

2085-
@pytest.mark.skipif(
2086-
config.cxx == "",
2087-
reason="SciPy and cxx needed",
2085+
@pytest.mark.skipif(config.cxx == "", reason="cxx needed")
2086+
@pytest.mark.xfail(
2087+
reason="Involves Ops with no Python implementation for numba to use as fallback"
20882088
)
20892089
class TestGroupedConv3dNoOptim(TestGroupedConvNoOptim):
20902090
conv = abstract_conv.AbstractConv3d

0 commit comments

Comments
 (0)