Modify get_scalar_constant_value to work with PyTensor Variables

Author: shreyas3156

pytensor/tensor/basic.py

@@ -267,9 +267,8 @@ def get_scalar_constant_value(
     If 'v' is not a scalar, it raises a NotScalarConstantError.
 
     """
-    if isinstance(v, np.ndarray):
-        data = v.data
-        if data.ndim != 0:
+    if isinstance(v, (Variable, np.ndarray)):
+        if v.ndim != 0:
             raise NotScalarConstantError()
     return get_underlying_scalar_constant_value(
         v, elemwise, only_process_constants, max_recur

tests/tensor/test_basic.py

@@ -3430,10 +3430,14 @@ def test_None_and_NoneConst(self, only_process_constants):
         )
 
 
-def test_get_scalar_constant_value():
+@pytest.mark.parametrize(
+    ["valid_inp", "invalid_inp"],
+    ((np.array(4), np.zeros(5)), (at.constant(4), at.constant(3, ndim=1))),
+)
+def test_get_scalar_constant_value(valid_inp, invalid_inp):
     with pytest.raises(NotScalarConstantError):
-        get_scalar_constant_value(np.zeros(5))
-    assert get_scalar_constant_value(np.array(4)) == 4
+        get_scalar_constant_value(invalid_inp)
+    assert get_scalar_constant_value(valid_inp) == 4
 
 
 def test_complex_mod_failure():