From 90a68f3b4044d2556869a2b5024163aec1e645ca Mon Sep 17 00:00:00 2001 From: Bill Engels Date: Sun, 10 Nov 2024 17:11:00 -0800 Subject: [PATCH 1/2] fix flaky test, remove high tolerance --- tests/gp/test_gp.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/gp/test_gp.py b/tests/gp/test_gp.py index 9265dd415f..ff4e35ad38 100644 --- a/tests/gp/test_gp.py +++ b/tests/gp/test_gp.py @@ -409,9 +409,9 @@ def testLatentMultioutput(self): == numpy_rv_logp.shape.eval() ) - npt.assert_allclose(latent_rv_logp.eval(), marginal_rv_logp.eval(), atol=5) - npt.assert_allclose(latent_rv_logp.eval(), numpy_rv_logp.eval(), atol=5) - npt.assert_allclose(marginal_rv_logp.eval(), numpy_rv_logp.eval(), atol=5) + npt.assert_allclose(latent_rv_logp.eval({"f": y}), marginal_rv_logp.eval()) + npt.assert_allclose(latent_rv_logp.eval({"f": y}), numpy_rv_logp.eval()) + npt.assert_allclose(marginal_rv_logp.eval(), numpy_rv_logp.eval()) class TestTP: From 27058f35c26bc5f0ef1a8b8083b38eb539442192 Mon Sep 17 00:00:00 2001 From: Bill Engels Date: Mon, 11 Nov 2024 16:23:15 -0800 Subject: [PATCH 2/2] increase rtol --- tests/gp/test_gp.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/gp/test_gp.py b/tests/gp/test_gp.py index ff4e35ad38..3d620610fd 100644 --- a/tests/gp/test_gp.py +++ b/tests/gp/test_gp.py @@ -409,9 +409,9 @@ def testLatentMultioutput(self): == numpy_rv_logp.shape.eval() ) - npt.assert_allclose(latent_rv_logp.eval({"f": y}), marginal_rv_logp.eval()) - npt.assert_allclose(latent_rv_logp.eval({"f": y}), numpy_rv_logp.eval()) - npt.assert_allclose(marginal_rv_logp.eval(), numpy_rv_logp.eval()) + npt.assert_allclose(latent_rv_logp.eval({"f": y}), marginal_rv_logp.eval(), rtol=1e-4) + npt.assert_allclose(latent_rv_logp.eval({"f": y}), numpy_rv_logp.eval(), rtol=1e-4) + npt.assert_allclose(marginal_rv_logp.eval(), numpy_rv_logp.eval(), rtol=1e-4) class TestTP: