-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add return type hints #5819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add return type hints #5819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #4880
Codecov Report
@@ Coverage Diff @@
## main #5819 +/- ##
==========================================
- Coverage 89.39% 89.37% -0.02%
==========================================
Files 74 74
Lines 13767 13770 +3
==========================================
Hits 12307 12307
- Misses 1460 1463 +3
|
ricardoV94
reviewed
May 29, 2022
Co-authored-by: Ricardo Vieira <28983449+ricardoV94@users.noreply.github.com>
michaelosthege
commented
May 29, 2022
@ricardoV94 can I squash merge this? |
1 similar comment
@ricardoV94 can I squash merge this? |
ricardoV94
approved these changes
May 30, 2022
Sure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4880
I know the ticket is about docstrings, but Sphinx can take the type information from the code automatically, so it should be enough to keep a single source of truth.
With this all functions in that file have annotated return types.
And in the end I just want to get the ticket out of the way.