Skip to content

Add return type hints #5819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 30, 2022
Merged

Add return type hints #5819

merged 6 commits into from
May 30, 2022

Conversation

michaelosthege
Copy link
Member

Closes #4880

I know the ticket is about docstrings, but Sphinx can take the type information from the code automatically, so it should be enough to keep a single source of truth.

With this all functions in that file have annotated return types.

And in the end I just want to get the ticket out of the way.

@michaelosthege michaelosthege requested a review from canyon289 May 29, 2022 11:32
@codecov
Copy link

codecov bot commented May 29, 2022

Codecov Report

Merging #5819 (bb569e2) into main (4d2f3a8) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5819      +/-   ##
==========================================
- Coverage   89.39%   89.37%   -0.02%     
==========================================
  Files          74       74              
  Lines       13767    13770       +3     
==========================================
  Hits        12307    12307              
- Misses       1460     1463       +3     
Impacted Files Coverage Δ
pymc/distributions/distribution.py 90.83% <ø> (ø)
pymc/aesaraf.py 91.95% <100.00%> (+0.06%) ⬆️
pymc/distributions/logprob.py 97.65% <100.00%> (ø)
pymc/parallel_sampling.py 86.46% <0.00%> (-1.00%) ⬇️

michaelosthege and others added 3 commits May 29, 2022 17:38
Co-authored-by: Ricardo Vieira <28983449+ricardoV94@users.noreply.github.com>
@michaelosthege
Copy link
Member Author

@ricardoV94 can I squash merge this?
Just to get it out of the way..

1 similar comment
@michaelosthege
Copy link
Member Author

@ricardoV94 can I squash merge this?
Just to get it out of the way..

@ricardoV94
Copy link
Member

@ricardoV94 can I squash merge this? Just to get it out of the way..

Sure

@michaelosthege michaelosthege merged commit 6b22ed5 into main May 30, 2022
@michaelosthege michaelosthege deleted the issue-4880 branch May 30, 2022 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add return types in docstrings for logprob.py
2 participants