Skip to content

MAINT: small changes to speed up find_MAP #3916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2020

Conversation

tirthasheshpatel
Copy link
Contributor

Changes:

  • removes un-necessary calls to bij.map.
  • adds a new line after find_MAP finishes to avoid the progress bar to be overwritten (only if progressbar=True)

@codecov
Copy link

codecov bot commented May 10, 2020

Codecov Report

Merging #3916 into master will increase coverage by 0.00%.
The diff coverage is 33.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3916   +/-   ##
=======================================
  Coverage   83.45%   83.45%           
=======================================
  Files         103      103           
  Lines       14178    14179    +1     
=======================================
+ Hits        11832    11833    +1     
  Misses       2346     2346           
Impacted Files Coverage Δ
pymc3/tuning/starting.py 80.91% <33.33%> (+0.14%) ⬆️

Copy link
Member

@michaelosthege michaelosthege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks tidier 👍

However they were just calling bij.map once, so it was not much of a performance loss.

@michaelosthege michaelosthege added this to the 3.9 milestone May 12, 2020
@twiecki twiecki merged commit effe5c4 into pymc-devs:master May 12, 2020
@twiecki
Copy link
Member

twiecki commented May 12, 2020

Thanks!

@tirthasheshpatel tirthasheshpatel deleted the small-fix branch May 12, 2020 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants