Fix shape_utils missing functions and misformatted returns #7006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and include type hints in docstring pymc-devs#7004
|
|
twiecki
approved these changes
Nov 11, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #7006 +/- ##
==========================================
- Coverage 92.19% 92.13% -0.06%
==========================================
Files 101 101
Lines 16921 16921
==========================================
- Hits 15600 15590 -10
- Misses 1321 1331 +10
|
ricardoV94
requested changes
Nov 11, 2023
ricardoV94
approved these changes
Nov 13, 2023
|
Hi @ricardoV94 , I tried to sovle this pre-commit Failure. But unable to fix this. Please guide me. |
|
/pre-commit-run |
|
Hi @twiecki the pre-commit issue is still unresolved. What else can i do on this PR. |
|
@UditNayak You need to run pre-commit locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR about?
Fixes #7004
The shape_utils module was missing functions in the documentation. Additionally, the rendering of returns for certain functions was identified as messy. The focus of this PR is to include type hints in the docstring, in line with the suggested improvement.
Checklist
Documentation
📚 Documentation preview 📚: https://pymc--7006.org.readthedocs.build/en/7006/