Fix compute_test_value error when creating observed variables (#6982)

Co-authored-by: Ricardo Vieira <ricardo.vieira1994@gmail.com>

Author: vandalt

pymc/model/core.py

@@ -1347,15 +1347,6 @@ def make_obs_var(
                 "Dimensionality of data and RV don't match.", actual=data.ndim, expected=rv_var.ndim
             )
 
-        if pytensor.config.compute_test_value != "off":
-            test_value = getattr(rv_var.tag, "test_value", None)
-
-            if test_value is not None:
-                # We try to reuse the old test value
-                rv_var.tag.test_value = np.broadcast_to(test_value, rv_var.shape)
-            else:
-                rv_var.tag.test_value = data
-
         mask = getattr(data, "mask", None)
         if mask is not None:
             impute_message = (

tests/model/test_core.py

@@ -223,6 +223,14 @@ def test_observed_type(self):
         assert x1.type.dtype == X.type.dtype
         assert x2.type.dtype == X.type.dtype
 
+    @pytensor.config.change_flags(compute_test_value="raise")
+    def test_observed_compute_test_value(self):
+        data = np.zeros(100)
+        with pm.Model():
+            obs = pm.Normal("obs", mu=pt.zeros_like(data), sigma=1, observed=data)
+        assert obs.tag.test_value.shape == data.shape
+        assert obs.tag.test_value.dtype == data.dtype
+
 
 def test_duplicate_vars():
     with pytest.raises(ValueError) as err: