Skip to content

Commit 33ce136

Browse files
committed
Create value variable on transformed space
1 parent 24888ac commit 33ce136

File tree

1 file changed

+15
-9
lines changed

1 file changed

+15
-9
lines changed

pymc/model.py

Lines changed: 15 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1460,28 +1460,34 @@ def create_value_var(
14601460
14611461
"""
14621462
if value_var is None:
1463-
value_var = rv_var.type()
1464-
value_var.name = rv_var.name
1465-
1466-
if aesara.config.compute_test_value != "off":
1467-
value_var.tag.test_value = rv_var.tag.test_value
1468-
1469-
_add_future_warning_tag(value_var)
1470-
rv_var.tag.value_var = value_var
1463+
untransformed_value_var = rv_var.type()
1464+
untransformed_value_var.name = rv_var.name
1465+
else:
1466+
untransformed_value_var = value_var
14711467

14721468
# Make the value variable a transformed value variable,
14731469
# if there's an applicable transform
14741470
if transform is UNSET and rv_var.owner:
14751471
transform = _default_transform(rv_var.owner.op, rv_var)
14761472

14771473
if transform is not None and transform is not UNSET:
1474+
value_var = transform.forward(untransformed_value_var, *rv_var.owner.inputs).type()
1475+
value_var.name = f"{untransformed_value_var.name}_{transform.name}__"
14781476
value_var.tag.transform = transform
1479-
value_var.name = f"{value_var.name}_{transform.name}__"
14801477
if aesara.config.compute_test_value != "off":
14811478
value_var.tag.test_value = transform.forward(
14821479
value_var, *rv_var.owner.inputs
14831480
).tag.test_value
14841481
self.named_vars[value_var.name] = value_var
1482+
else:
1483+
value_var = untransformed_value_var
1484+
1485+
if aesara.config.compute_test_value != "off":
1486+
value_var.tag.test_value = rv_var.tag.test_value
1487+
1488+
_add_future_warning_tag(value_var)
1489+
rv_var.tag.value_var = value_var
1490+
14851491
self.rvs_to_transforms[rv_var] = transform
14861492
self.rvs_to_values[rv_var] = value_var
14871493
self.values_to_rvs[value_var] = rv_var

0 commit comments

Comments
 (0)