Skip to content

Commit ec053e5

Browse files
Test parameterizations use correct parameter shapes
1 parent 6ac1d0d commit ec053e5

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

pymc_experimental/tests/statespace/test_SARIMAX.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -297,9 +297,7 @@ def test_SARIMAX_update_matches_statsmodels(p, d, q, P, D, Q, S, data, rng):
297297
),
298298
)
299299

300-
pm.Deterministic(
301-
"sigma_state", pt.as_tensor_variable(np.sqrt(np.array([param_d["sigma2"]])))
302-
)
300+
pm.Deterministic("sigma_state", pt.as_tensor_variable(np.sqrt(param_d["sigma2"])))
303301

304302
mod._insert_random_variables()
305303
matrices = pm.draw(mod.subbed_ssm)

pymc_experimental/tests/statespace/test_structural.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,7 @@ def create_structural_model_and_equivalent_statsmodel(
196196
components = []
197197

198198
if irregular:
199-
sigma2 = np.abs(rng.normal(size=(1,))).astype(floatX)
199+
sigma2 = np.abs(rng.normal()).astype(floatX)
200200
params["sigma_irregular"] = np.sqrt(sigma2)
201201
sm_params["sigma2.irregular"] = sigma2.item()
202202
expected_param_dims["sigma_irregular"] += ("observed_state",)

0 commit comments

Comments
 (0)