Disable unused-argument request for views. Fix #155

in fact we disable this error just based on the argument name.
For functions it is not really possible to reliably determine if
the function is a real view that serves http requests or a
plain-old-function (maybe a helper) where the argument was named
'request'.

Author: atodorov

pylint_django/augmentations/__init__.py

@@ -645,7 +645,14 @@ def is_model_view_subclass_unused_argument(node):
     if not is_model_view_subclass_method_shouldnt_be_function(node):
         return False
 
-    return 'request' in node.argnames()
+    return is_argument_named_request(node)
+
+
+def is_argument_named_request(node):
+    """
+    If an unused-argument is named 'request' ignore that!
+    """
+    return 'request'in node.argnames()
 
 
 def is_model_field_display_method(node):
@@ -833,7 +840,9 @@ def apply_augmentations(linter):
     # Method could be a function (get, post)
     suppress_message(linter, _leave_function(ClassChecker), 'R0201', is_model_view_subclass_method_shouldnt_be_function)
     # Unused argument 'request' (get, post)
-    suppress_message(linter, _leave_function(VariablesChecker), 'W0613', is_model_view_subclass_unused_argument)
+    suppress_message(linter, _leave_function(VariablesChecker), 'unused-argument',
+                     is_model_view_subclass_unused_argument)
+    suppress_message(linter, _leave_function(VariablesChecker), 'unused-argument', is_argument_named_request)
 
     # django-mptt
     suppress_message(linter, _visit_class(DocStringChecker), 'missing-docstring', is_model_mpttmeta_subclass)

pylint_django/tests/input/func_noerror_views.py

@@ -0,0 +1,8 @@
+"""
+Checks that Pylint does not complain when using function based views.
+"""
+#  pylint: disable=missing-docstring
+
+
+def empty_view(request):
+    pass