Merge pull request #159 from trbs/master

add suppression for members of Django Style class

Author: carlio

pylint_django/augmentations/__init__.py

@@ -1,5 +1,7 @@
 """Augmentations."""
 #  pylint: disable=invalid-name
+import itertools
+
 from astroid import InferenceError
 from astroid.objects import Super
 from astroid.nodes import ClassDef, ImportFrom, Attribute
@@ -22,6 +24,7 @@
 from django.views.generic.detail import SingleObjectMixin, SingleObjectTemplateResponseMixin, TemplateResponseMixin
 from django.views.generic.edit import DeletionMixin, FormMixin, ModelFormMixin
 from django.views.generic.list import MultipleObjectMixin, MultipleObjectTemplateResponseMixin
+from django.utils import termcolors
 
 from pylint_django.utils import node_is_subclass, PY3
 
@@ -258,6 +261,9 @@
 }
 
 
+STYLE_ATTRS = set(itertools.chain.from_iterable(termcolors.PALETTES.values()))
+
+
 VIEW_ATTRS = {
     (
         (
@@ -472,6 +478,11 @@ def _attribute_is_magic(node, attrs, parents):
     return False
 
 
+def is_style_attribute(node):
+    parents = ('django.core.management.color.Style', )
+    return _attribute_is_magic(node, STYLE_ATTRS, parents)
+
+
 def is_manager_attribute(node):
     """Checks that node is attribute of Manager or QuerySet class."""
     parents = ('django.db.models.manager.Manager',
@@ -757,6 +768,7 @@ def apply_augmentations(linter):
     augment_visit(linter, _visit_attribute(TypeChecker), foreign_key_sets)
     augment_visit(linter, _visit_attribute(TypeChecker), foreign_key_ids)
     suppress_message(linter, _visit_attribute(TypeChecker), 'no-member', is_model_field_display_method)
+    suppress_message(linter, _visit_attribute(TypeChecker), 'no-member', is_style_attribute)
 
     # supress errors when accessing magical class attributes
     suppress_message(linter, _visit_attribute(TypeChecker), 'no-member', is_manager_attribute)

pylint_django/tests/input/func_noerror_style_members.py

@@ -0,0 +1,14 @@
+# Test that using `color_style` or `no_style`
+# doesn't raise no-member error
+#
+# pylint: disable=missing-docstring
+
+from django.core.management.color import color_style, no_style
+
+
+def function():
+    style = color_style()
+    print(style.SUCCESS("test"))
+
+    style = no_style()
+    print(style.SUCCESS("test"))