Skip to content

Commit ebaa195

Browse files
committed
The code to unlink dropped relations in FinishPreparedTransaction() was
acting like runs inside WAL recovery, but it doesn't. I must've copy-pasted this from a redo-function in the relation forks patch. Noticed by Tom Lane while he was looking through callers of smgrdounlink().
1 parent 8fd733b commit ebaa195

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

src/backend/access/transam/twophase.c

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* Portions Copyright (c) 1994, Regents of the University of California
88
*
99
* IDENTIFICATION
10-
* $PostgreSQL: pgsql/src/backend/access/transam/twophase.c,v 1.53 2009/06/11 14:48:54 momjian Exp $
10+
* $PostgreSQL: pgsql/src/backend/access/transam/twophase.c,v 1.54 2009/06/25 19:05:52 heikki Exp $
1111
*
1212
* NOTES
1313
* Each global transaction is associated with a global transaction
@@ -1241,10 +1241,7 @@ FinishPreparedTransaction(const char *gid, bool isCommit)
12411241
for (fork = 0; fork <= MAX_FORKNUM; fork++)
12421242
{
12431243
if (smgrexists(srel, fork))
1244-
{
1245-
XLogDropRelation(delrels[i], fork);
1246-
smgrdounlink(srel, fork, false, true);
1247-
}
1244+
smgrdounlink(srel, fork, false, false);
12481245
}
12491246
smgrclose(srel);
12501247
}

0 commit comments

Comments
 (0)