Skip to content

Commit 520ec24

Browse files
committed
Fix race condition in committing a serializable transaction
The finished transaction list can contain XIDs that are older than the serializable global xmin. It's a short-lived state; ClearOldPredicateLocks() removes any such transactions from the list, and it's called whenever the global xmin advances. But if another backend calls SummarizeOldestCommittedSxact() in that window, it will call SerialAdd() on an XID that's older than the global xmin, or if there are no more transactions running, when global xmin is invalid. That trips the assertion in SerialAdd(). Fixes bug #18658 reported by Andrew Bille. Thanks to Alexander Lakhin for analysis. Backpatch to all versions. Discussion: https://www.postgresql.org/message-id/18658-7dab125ec688c70b%40postgresql.org
1 parent fbbcbde commit 520ec24

File tree

1 file changed

+9
-4
lines changed

1 file changed

+9
-4
lines changed

src/backend/storage/lmgr/predicate.c

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -918,12 +918,17 @@ SerialAdd(TransactionId xid, SerCommitSeqNo minConflictCommitSeqNo)
918918
LWLockAcquire(SerialSLRULock, LW_EXCLUSIVE);
919919

920920
/*
921-
* If no serializable transactions are active, there shouldn't be anything
922-
* to push out to the SLRU. Hitting this assert would mean there's
923-
* something wrong with the earlier cleanup logic.
921+
* If 'xid' is older than the global xmin (== tailXid), there's no need to
922+
* store it, after all. This can happen if the oldest transaction holding
923+
* back the global xmin just finished, making 'xid' uninteresting, but
924+
* ClearOldPredicateLocks() has not yet run.
924925
*/
925926
tailXid = serialControl->tailXid;
926-
Assert(TransactionIdIsValid(tailXid));
927+
if (!TransactionIdIsValid(tailXid) || TransactionIdPrecedes(xid, tailXid))
928+
{
929+
LWLockRelease(SerialSLRULock);
930+
return;
931+
}
927932

928933
/*
929934
* If the SLRU is currently unused, zero out the whole active region from

0 commit comments

Comments
 (0)