Skip to content

Commit 80a94c5

Browse files
authored
Merge pull request #613 from addisonlynch/compat-pandas-concat
COMPAT: Added explicit sort parameter to pd.concat in Yahoo Actions
2 parents 13c5424 + dfec5f2 commit 80a94c5

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

pandas_datareader/yahoo/actions.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,14 +33,16 @@ def _get_one_action(data):
3333
dividends = DataFrame(data['Dividends']).dropna()
3434
dividends["action"] = "DIVIDEND"
3535
dividends = dividends.rename(columns={'Dividends': 'value'})
36-
actions = concat([actions, dividends]).sort_index(ascending=False)
36+
actions = concat([actions, dividends], sort=True)
37+
actions = actions.sort_index(ascending=False)
3738

3839
if 'Splits' in data.columns:
3940
# Add a label column so we can combine our two DFs
4041
splits = DataFrame(data['Splits']).dropna()
4142
splits["action"] = "SPLIT"
4243
splits = splits.rename(columns={'Splits': 'value'})
43-
actions = concat([actions, splits]).sort_index(ascending=False)
44+
actions = concat([actions, splits], sort=True)
45+
actions = actions.sort_index(ascending=False)
4446

4547
return actions
4648

0 commit comments

Comments
 (0)