Skip to content

Commit c58ff7f

Browse files
authored
fix dirint pressure bug (#213)
1 parent 85e0e00 commit c58ff7f

File tree

3 files changed

+7
-5
lines changed

3 files changed

+7
-5
lines changed

docs/sphinx/source/whatsnew/v0.4.0.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,8 @@ Enhancements
2727
Bug fixes
2828
~~~~~~~~~
2929

30+
* dirint function yielded the wrong results for non-sea-level pressures.
31+
Fixed. (:issue:`212`)
3032

3133

3234
Documentation

pvlib/irradiance.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1470,7 +1470,7 @@ def dirint(ghi, zenith, times, pressure=101325, use_delta_kt_prime=True,
14701470

14711471
pvl_logger.debug('clearsky.dirint')
14721472

1473-
disc_out = disc(ghi, zenith, times)
1473+
disc_out = disc(ghi, zenith, times, pressure=pressure)
14741474
kt = disc_out['kt']
14751475

14761476
# Absolute Airmass, per the DISC model

pvlib/test/test_irradiance.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -208,7 +208,7 @@ def test_dirint_value():
208208
pressure = 93193.
209209
dirint_data = irradiance.dirint(ghi, zenith, times, pressure=pressure)
210210
assert_almost_equal(dirint_data.values,
211-
np.array([928.85, 688.26]), 1)
211+
np.array([ 888. , 683.7]), 1)
212212

213213

214214
def test_dirint_nans():
@@ -220,7 +220,7 @@ def test_dirint_nans():
220220
dirint_data = irradiance.dirint(ghi, zenith, times, pressure=pressure,
221221
temp_dew=temp_dew)
222222
assert_almost_equal(dirint_data.values,
223-
np.array([np.nan, np.nan, np.nan, np.nan, 934.2]), 1)
223+
np.array([np.nan, np.nan, np.nan, np.nan, 893.1]), 1)
224224

225225

226226
def test_dirint_tdew():
@@ -231,7 +231,7 @@ def test_dirint_tdew():
231231
dirint_data = irradiance.dirint(ghi, zenith, times, pressure=pressure,
232232
temp_dew=10)
233233
assert_almost_equal(dirint_data.values,
234-
np.array([934.06, 640.67]), 1)
234+
np.array([892.9, 636.5]), 1)
235235

236236
def test_dirint_no_delta_kt():
237237
times = pd.DatetimeIndex(['2014-06-24T12-0700','2014-06-24T18-0700'])
@@ -241,7 +241,7 @@ def test_dirint_no_delta_kt():
241241
dirint_data = irradiance.dirint(ghi, zenith, times, pressure=pressure,
242242
use_delta_kt_prime=False)
243243
assert_almost_equal(dirint_data.values,
244-
np.array([901.56, 674.87]), 1)
244+
np.array([861.9, 670.4]), 1)
245245

246246
def test_dirint_coeffs():
247247
coeffs = irradiance._get_dirint_coeffs()

0 commit comments

Comments
 (0)