Skip to content

Commit b40df75

Browse files
authored
Make sure times are assigned with ModelChain.run_from_poa (#1162)
* Make sure times are assigned with ModelChain.run_from_poa * move _assign_times to _assign_weather
1 parent 5a5d4aa commit b40df75

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

pvlib/modelchain.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1324,6 +1324,7 @@ def _build_weather(data):
13241324
_build_weather(weather) for weather in data
13251325
)
13261326
self._configure_results()
1327+
self._assign_times()
13271328
return self
13281329

13291330
def _assign_total_irrad(self, data):
@@ -1392,7 +1393,6 @@ def prepare_inputs(self, weather):
13921393
self._check_multiple_input(weather, strict=False)
13931394
self._verify_df(weather, required=['ghi', 'dni', 'dhi'])
13941395
self._assign_weather(weather)
1395-
self._assign_times()
13961396

13971397
self._prep_inputs_solar_pos(weather)
13981398
self._prep_inputs_airmass()

pvlib/tests/test_modelchain.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -774,6 +774,7 @@ def test_prepare_inputs_from_poa(sapm_dc_snl_ac_system, location,
774774
assert_frame_equal(mc.weather, weather_expected)
775775
# total_irrad attribute
776776
assert_frame_equal(mc.results.total_irrad, total_irrad)
777+
assert not pd.isnull(mc.results.solar_position.index[0])
777778

778779

779780
@pytest.mark.parametrize("input_type", [tuple, list])

0 commit comments

Comments
 (0)