Skip to content

Commit 96e7eb3

Browse files
committed
more tests for location
1 parent 9025cfc commit 96e7eb3

File tree

2 files changed

+37
-6
lines changed

2 files changed

+37
-6
lines changed

pvlib/location.py

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,7 @@
22
This module contains the Location class.
33
"""
44

5-
# Will Holmgren, University of Arizona, 2014.
6-
7-
import logging
8-
pvl_logger = logging.getLogger('pvlib')
5+
# Will Holmgren, University of Arizona, 2014-2016.
96

107
import datetime
118

@@ -190,7 +187,7 @@ def get_clearsky(self, times, model='ineichen', **kwargs):
190187
191188
Returns
192189
-------
193-
clearsky : Series or DataFrame
190+
clearsky : DataFrame
194191
Column names are: ``ghi, dni, dhi``.
195192
"""
196193

pvlib/test/test_location.py

Lines changed: 35 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,32 @@ def test_get_clearsky():
6262
assert_frame_equal(expected, clearsky)
6363

6464

65+
def test_get_clearsky_haurwitz():
66+
tus = Location(32.2, -111, 'US/Arizona', 700, 'Tucson')
67+
times = pd.DatetimeIndex(start='20160101T0600-0700',
68+
end='20160101T1800-0700',
69+
freq='3H')
70+
clearsky = tus.get_clearsky(times, model='haurwitz')
71+
expected = pd.DataFrame(data=np.array(
72+
[[ 0. ],
73+
[ 242.30085588],
74+
[ 559.38247117],
75+
[ 384.6873791 ],
76+
[ 0. ]]),
77+
columns=['ghi'],
78+
index=times)
79+
assert_frame_equal(expected, clearsky)
80+
81+
82+
@raises(ValueError)
83+
def test_get_clearsky_valueerror():
84+
tus = Location(32.2, -111, 'US/Arizona', 700, 'Tucson')
85+
times = pd.DatetimeIndex(start='20160101T0600-0700',
86+
end='20160101T1800-0700',
87+
freq='3H')
88+
clearsky = tus.get_clearsky(times, model='invalid_model')
89+
90+
6591
def test_from_tmy_3():
6692
from .test_tmy import tmy3_testfile
6793
from ..tmy import readtmy3
@@ -125,4 +151,12 @@ def test_get_airmass():
125151
columns=['airmass_relative', 'airmass_absolute'],
126152
index=times)
127153
assert_frame_equal(expected, airmass)
128-
154+
155+
156+
@raises(ValueError)
157+
def test_get_airmass_valueerror():
158+
tus = Location(32.2, -111, 'US/Arizona', 700, 'Tucson')
159+
times = pd.DatetimeIndex(start='20160101T0600-0700',
160+
end='20160101T1800-0700',
161+
freq='3H')
162+
clearsky = tus.get_airmass(times, model='invalid_model')

0 commit comments

Comments
 (0)