Skip to content

Commit 06eca3f

Browse files
committed
update test_irradiance
1 parent 56e52db commit 06eca3f

File tree

2 files changed

+16
-3
lines changed

2 files changed

+16
-3
lines changed

pvlib/irradiance.py

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
pvl_logger = logging.getLogger('pvlib')
1212

1313
import datetime
14+
from collections import OrderedDict
1415

1516
import numpy as np
1617
import pandas as pd
@@ -2043,6 +2044,12 @@ def liujordan(zenith, transmittance, airmass, pressure=101325.,
20432044
dhi = 0.3 * (1.0 - tao**airmass) * dni_extra * np.cos(np.radians(zenith))
20442045
ghi = dhi + dni * np.cos(np.radians(zenith))
20452046

2046-
irrads = pd.DataFrame({'ghi': ghi, 'dni': dni, 'dhi': dhi})
2047+
irrads = OrderedDict()
2048+
irrads['ghi'] = ghi
2049+
irrads['dni'] = dni
2050+
irrads['dhi'] = dhi
2051+
2052+
if isinstance(ghi, pd.Series):
2053+
irrads = pd.DataFrame(irrads)
20472054

20482055
return irrads

pvlib/test/test_irradiance.py

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -142,8 +142,14 @@ def test_perez():
142142

143143

144144
def test_liujordan():
145-
cloud_prct = np.array([40]*len(ephem_data['apparent_zenith']))
146-
irradiance.liujordan(ephem_data['apparent_zenith'], cloud_prct)
145+
expected = pd.DataFrame(np.
146+
array([[863.859736967, 653.123094076, 220.65905025]]),
147+
columns=['ghi', 'dni', 'dhi'],
148+
index=[0])
149+
out = irradiance.liujordan(
150+
pd.Series([10]), pd.Series([0.5]), pd.Series([1.1]),
151+
pressure=93000., dni_extra=1400)
152+
assert_frame_equal(out, expected)
147153

148154

149155
# klutcher (misspelling) will be removed in 0.3

0 commit comments

Comments
 (0)