From 1fb9b769e2c39219c29feb66a08ba83a79e157bf Mon Sep 17 00:00:00 2001 From: Jordan Martinez Date: Fri, 25 Mar 2022 09:25:55 -0500 Subject: [PATCH 1/3] Deduplicate set/getClassName & classList --- src/Web/HTML/HTMLElement.js | 22 ---------------------- src/Web/HTML/HTMLElement.purs | 8 -------- 2 files changed, 30 deletions(-) diff --git a/src/Web/HTML/HTMLElement.js b/src/Web/HTML/HTMLElement.js index 2349404..65e2431 100644 --- a/src/Web/HTML/HTMLElement.js +++ b/src/Web/HTML/HTMLElement.js @@ -57,28 +57,6 @@ export function setDir(dir) { // ---------------------------------------------------------------------------- -export function className(elt) { - return function () { - return elt.className; - }; -} - -export function setClassName(className) { - return function (elt) { - return function () { - elt.className = className; - }; - }; -} - -export function classList(element) { - return function () { - return element.classList; - }; -} - -// ---------------------------------------------------------------------------- - export function hidden(elt) { return function () { return elt.hidden; diff --git a/src/Web/HTML/HTMLElement.purs b/src/Web/HTML/HTMLElement.purs index d310cd3..6397d5e 100644 --- a/src/Web/HTML/HTMLElement.purs +++ b/src/Web/HTML/HTMLElement.purs @@ -18,9 +18,6 @@ module Web.HTML.HTMLElement , setLang , dir , setDir - , className - , setClassName - , classList , hidden , setHidden , tabIndex @@ -106,11 +103,6 @@ foreign import setLang :: String -> HTMLElement -> Effect Unit foreign import dir :: HTMLElement -> Effect String foreign import setDir :: String -> HTMLElement -> Effect Unit -foreign import className :: HTMLElement -> Effect String -foreign import setClassName :: String -> HTMLElement -> Effect Unit - -foreign import classList :: HTMLElement -> Effect DOMTokenList - foreign import hidden :: HTMLElement -> Effect Boolean foreign import setHidden :: Boolean -> HTMLElement -> Effect Unit From 2398b26986f684313da779da0d714c6662152281 Mon Sep 17 00:00:00 2001 From: Jordan Martinez Date: Fri, 25 Mar 2022 09:26:34 -0500 Subject: [PATCH 2/3] Update changelog --- CHANGELOG.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 8cd30b3..98c33b6 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,9 @@ Notable changes to this project are documented in this file. The format is based Breaking changes: - Move `getBoundingClientRect` to `purescript-web-dom` (#73 by @JordanMartinez) +- Drop duplicated `set/getClassName` and `classList` (#74 by @JordanMartinez) + + These three entities are already defined in `purescript-web-dom` New features: From 7a374a49346b3e7841723067c497ae32ab4d5019 Mon Sep 17 00:00:00 2001 From: Thomas Honeyman Date: Fri, 25 Mar 2022 10:30:50 -0400 Subject: [PATCH 3/3] Update HTMLElement.purs --- src/Web/HTML/HTMLElement.purs | 1 - 1 file changed, 1 deletion(-) diff --git a/src/Web/HTML/HTMLElement.purs b/src/Web/HTML/HTMLElement.purs index 6397d5e..0311f82 100644 --- a/src/Web/HTML/HTMLElement.purs +++ b/src/Web/HTML/HTMLElement.purs @@ -47,7 +47,6 @@ import Data.Nullable (Nullable, toMaybe) import Effect (Effect) import Unsafe.Coerce (unsafeCoerce) import Web.DOM (ChildNode) -import Web.DOM.DOMTokenList (DOMTokenList) import Web.DOM.Element (Element) import Web.DOM.Internal.Types (Node) import Web.DOM.NonDocumentTypeChildNode (NonDocumentTypeChildNode)