From 100ad1f1b21d72bc861526aa6647224040e1096e Mon Sep 17 00:00:00 2001 From: Jordan Martinez Date: Thu, 24 Mar 2022 21:30:59 -0500 Subject: [PATCH 1/2] Drop getBoundingClientRect --- src/Web/HTML/HTMLElement.js | 14 -------------- src/Web/HTML/HTMLElement.purs | 13 ------------- 2 files changed, 27 deletions(-) diff --git a/src/Web/HTML/HTMLElement.js b/src/Web/HTML/HTMLElement.js index aee4f0c..2349404 100644 --- a/src/Web/HTML/HTMLElement.js +++ b/src/Web/HTML/HTMLElement.js @@ -185,20 +185,6 @@ export function blur(elt) { // - CSSOM --------------------------------------------------------------------- -export function getBoundingClientRect(el) { - return function () { - var rect = el.getBoundingClientRect(); - return { - top: rect.top, - right: rect.right, - bottom: rect.bottom, - left: rect.left, - width: rect.width, - height: rect.height - }; - }; -} - export function _offsetParent(el) { return function () { return el.offsetParent; diff --git a/src/Web/HTML/HTMLElement.purs b/src/Web/HTML/HTMLElement.purs index 93e0d1f..d310cd3 100644 --- a/src/Web/HTML/HTMLElement.purs +++ b/src/Web/HTML/HTMLElement.purs @@ -35,8 +35,6 @@ module Web.HTML.HTMLElement , click , focus , blur - , getBoundingClientRect - , DOMRect , offsetParent , offsetTop , offsetLeft @@ -133,17 +131,6 @@ foreign import click :: HTMLElement -> Effect Unit foreign import focus :: HTMLElement -> Effect Unit foreign import blur :: HTMLElement -> Effect Unit -type DOMRect = - { top :: Number - , right :: Number - , bottom :: Number - , left :: Number - , width :: Number - , height :: Number - } - -foreign import getBoundingClientRect :: HTMLElement -> Effect DOMRect - foreign import _offsetParent :: HTMLElement -> Effect (Nullable Element) offsetParent :: HTMLElement -> Effect (Maybe Element) From c59f9bc6a1f0edd9e390e3a85a17bd970a2c6d55 Mon Sep 17 00:00:00 2001 From: Jordan Martinez Date: Thu, 24 Mar 2022 21:32:18 -0500 Subject: [PATCH 2/2] Add changelog entry --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 85fa04a..8cd30b3 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,7 @@ Notable changes to this project are documented in this file. The format is based ## [Unreleased] Breaking changes: +- Move `getBoundingClientRect` to `purescript-web-dom` (#73 by @JordanMartinez) New features: