Skip to content

Commit 093071b

Browse files
Deduplicate get/setClassName and classList (#74)
* Deduplicate set/getClassName & classList * Update changelog * Update HTMLElement.purs Co-authored-by: Thomas Honeyman <hello@thomashoneyman.com>
1 parent 469f30c commit 093071b

File tree

3 files changed

+3
-31
lines changed

3 files changed

+3
-31
lines changed

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,9 @@ Notable changes to this project are documented in this file. The format is based
66

77
Breaking changes:
88
- Move `getBoundingClientRect` to `purescript-web-dom` (#73 by @JordanMartinez)
9+
- Drop duplicated `set/getClassName` and `classList` (#74 by @JordanMartinez)
10+
11+
These three entities are already defined in `purescript-web-dom`
912

1013
New features:
1114

src/Web/HTML/HTMLElement.js

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -57,28 +57,6 @@ export function setDir(dir) {
5757

5858
// ----------------------------------------------------------------------------
5959

60-
export function className(elt) {
61-
return function () {
62-
return elt.className;
63-
};
64-
}
65-
66-
export function setClassName(className) {
67-
return function (elt) {
68-
return function () {
69-
elt.className = className;
70-
};
71-
};
72-
}
73-
74-
export function classList(element) {
75-
return function () {
76-
return element.classList;
77-
};
78-
}
79-
80-
// ----------------------------------------------------------------------------
81-
8260
export function hidden(elt) {
8361
return function () {
8462
return elt.hidden;

src/Web/HTML/HTMLElement.purs

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,6 @@ module Web.HTML.HTMLElement
1818
, setLang
1919
, dir
2020
, setDir
21-
, className
22-
, setClassName
23-
, classList
2421
, hidden
2522
, setHidden
2623
, tabIndex
@@ -50,7 +47,6 @@ import Data.Nullable (Nullable, toMaybe)
5047
import Effect (Effect)
5148
import Unsafe.Coerce (unsafeCoerce)
5249
import Web.DOM (ChildNode)
53-
import Web.DOM.DOMTokenList (DOMTokenList)
5450
import Web.DOM.Element (Element)
5551
import Web.DOM.Internal.Types (Node)
5652
import Web.DOM.NonDocumentTypeChildNode (NonDocumentTypeChildNode)
@@ -106,11 +102,6 @@ foreign import setLang :: String -> HTMLElement -> Effect Unit
106102
foreign import dir :: HTMLElement -> Effect String
107103
foreign import setDir :: String -> HTMLElement -> Effect Unit
108104

109-
foreign import className :: HTMLElement -> Effect String
110-
foreign import setClassName :: String -> HTMLElement -> Effect Unit
111-
112-
foreign import classList :: HTMLElement -> Effect DOMTokenList
113-
114105
foreign import hidden :: HTMLElement -> Effect Boolean
115106
foreign import setHidden :: Boolean -> HTMLElement -> Effect Unit
116107

0 commit comments

Comments
 (0)