Skip to content

Commit 7d71dc7

Browse files
authored
Merge pull request #29 from vaibhavsagar/ps-0.11-fix-warnings
Fix warnings
2 parents ee3b269 + 7a232b3 commit 7d71dc7

File tree

3 files changed

+12
-21
lines changed

3 files changed

+12
-21
lines changed

src/Data/Argonaut/Decode/Class.purs

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,22 +5,18 @@ module Data.Argonaut.Decode.Class
55

66
import Prelude
77

8-
import Data.Argonaut.Core (Json, JArray, JObject, isNull, foldJsonNull, foldJsonBoolean, foldJsonNumber, foldJsonString, toArray, toNumber, toObject, toString, toBoolean)
9-
import Data.Array (zipWithA)
8+
import Data.Argonaut.Core (Json, JArray, JObject, isNull, foldJsonNull, foldJsonBoolean, foldJsonNumber, foldJsonString, toArray, toObject, toString)
109
import Data.Bifunctor (lmap)
1110
import Data.Either (Either(..))
12-
import Data.Foldable (find)
1311
import Data.Int (fromNumber)
1412
import Data.List (List(..), (:), fromFoldable)
1513
import Data.Map as M
1614
import Data.Maybe (maybe, Maybe(..))
17-
import Data.String (charAt, toChar)
15+
import Data.String (charAt)
1816
import Data.StrMap as SM
19-
import Data.Traversable (traverse, for)
17+
import Data.Traversable (traverse)
2018
import Data.Tuple (Tuple(..))
2119

22-
import Type.Proxy (Proxy(..))
23-
2420
class DecodeJson a where
2521
decodeJson :: Json -> Either String a
2622

src/Data/Argonaut/Encode/Class.purs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ import Prelude
44

55
import Data.Argonaut.Core (Json(), jsonNull, fromBoolean, fromNumber, fromString, fromArray, fromObject, jsonEmptyObject, jsonSingletonObject)
66
import Data.Either (Either(), either)
7-
import Data.Foldable (foldr)
87
import Data.Int (toNumber)
98
import Data.List (List(..), (:), toUnfoldable)
109
import Data.Map as M

test/Test/Main.purs

Lines changed: 9 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -2,25 +2,21 @@ module Test.Main where
22

33
import Prelude
44

5-
import Control.Monad.Eff.Console (log, logShow)
5+
import Control.Monad.Eff.Console (log)
66

7-
import Data.Argonaut.Core (JObject, Json, isObject, toObject, fromObject, fromArray, fromString, fromNumber, fromBoolean, jsonNull)
7+
import Data.Argonaut.Core (JObject, Json, isObject, toObject)
88
import Data.Argonaut.Decode (decodeJson)
99
import Data.Argonaut.Encode (encodeJson, (:=), (~>))
1010
import Data.Argonaut.Gen (genJson)
11-
import Data.Array (zipWith, nubBy, length)
1211
import Data.Either (Either(..))
1312
import Data.Foldable (foldl)
14-
import Data.Function (on)
15-
import Data.List (fromFoldable)
1613
import Data.Maybe (Maybe(..), maybe, isJust)
1714
import Data.StrMap as SM
18-
import Data.Tuple (Tuple(..), fst)
15+
import Data.Tuple (Tuple(..))
1916

2017
import Test.StrongCheck (SC, quickCheck, quickCheck', (<?>))
21-
import Test.StrongCheck.Arbitrary (class Arbitrary, arbitrary)
22-
import Test.StrongCheck.Data.AlphaNumString (AlphaNumString(..))
23-
import Test.StrongCheck.Gen (Gen, Size, showSample, sized, frequency, oneOf, vectorOf, suchThat, resize)
18+
import Test.StrongCheck.Arbitrary (class Arbitrary)
19+
import Test.StrongCheck.Gen (suchThat, resize)
2420

2521
main :: SC () Unit
2622
main = do
@@ -80,17 +76,17 @@ combinatorsCheck = do
8076
prop_assoc_append (Tuple (Tuple key (TestJson val)) (Obj obj)) =
8177
let appended = (key := val) ~> obj
8278
in case toObject appended >>= SM.lookup key of
83-
Just val -> true
79+
Just value -> true
8480
_ -> false
8581

8682
prop_get_jobject_field :: Obj -> Boolean
8783
prop_get_jobject_field (Obj obj) =
8884
maybe false go $ toObject obj
8985
where
9086
go :: JObject -> Boolean
91-
go obj =
92-
let keys = SM.keys obj
93-
in foldl (\ok key -> ok && isJust (SM.lookup key obj)) true keys
87+
go object =
88+
let keys = SM.keys object
89+
in foldl (\ok key -> ok && isJust (SM.lookup key object)) true keys
9490

9591
eitherCheck :: SC () Unit
9692
eitherCheck = do

0 commit comments

Comments
 (0)