address rubocop

Author: pmcmaw

lib/puppet/functions/length.rb

@@ -4,15 +4,9 @@
     scope_param
     optional_repeated_param 'Any', :args
   end
-  def length(value)
-    if value.is_a?(String)
-      result = value.length
-    elsif value.is_a?(Array) || value.is_a?(Hash)
-      result = value.size
-    end
-    result
+
   def deprecation_gen(scope, *args)
-    call_function('deprecation', 'length', "This method is deprecated, this function is now shipped with Puppet in versions 5.5.0 and later. For more information please see Puppet 5.5.0 Release Notes.")
-    scope.send("function_length", args)
+    call_function('deprecation', 'length', 'This method is deprecated, this function is now shipped with Puppet in versions 5.5.0 and later. For more information please see Puppet 5.5.0 Release Notes.') # rubocop:disable Metrics/LineLength
+    scope.send('function_length', args)
   end
 end

spec/functions/keys_spec.rb

@@ -12,12 +12,12 @@
   it { is_expected.to run.with_params([]).and_raise_error(Puppet::ParseError, %r{Requires hash to work with}) } if Puppet.version < '5.5.0'
   it { is_expected.to run.with_params({}).and_return([]) }
   it { is_expected.to run.with_params('key' => 'value').and_return(['key']) }
-  it 'returns the array of keys', if: Puppet.version < '5.5.0' do
+  it 'returns the array of keys', :if => Puppet.version < '5.5.0' do
     result = subject.call([{ 'key1' => 'value1', 'key2' => 'value2' }])
     expect(result).to match_array(%w[key1 key2])
   end
 
-  it 'runs with UTF8 and double byte characters', if: Puppet.version < '5.5.0' do
+  it 'runs with UTF8 and double byte characters', :if => Puppet.version < '5.5.0' do
     result = subject.call([{ 'ҝểү' => '√ẳŀμệ', 'キー' => '値' }])
     expect(result).to match_array(%w[ҝểү キー])
   end

spec/functions/values_spec.rb

@@ -12,12 +12,12 @@
   it { is_expected.to run.with_params([]).and_raise_error(Puppet::ParseError, %r{Requires hash to work with}) } if Puppet.version < '5.5.0'
   it { is_expected.to run.with_params({}).and_return([]) }
   it { is_expected.to run.with_params('key' => 'value').and_return(['value']) }
-  it 'returns the array of values', if: Puppet.version < '5.5.0' do
+  it 'returns the array of values', :if => Puppet.version < '5.5.0' do
     result = subject.call([{ 'key1' => 'value1', 'key2' => 'value2', 'duplicate_value_key' => 'value2' }])
     expect(result).to match_array(%w[value1 value2 value2])
   end
 
-  it 'runs with UTF8 and double byte characters', if: Puppet.version < '5.5.0' do
+  it 'runs with UTF8 and double byte characters', :if => Puppet.version < '5.5.0' do
     result = subject.call([{ 'かぎ' => '使用', 'ҝĕұ' => '√ẩŀứệ', 'ҝĕұďŭрļǐçằťè' => '√ẩŀứệ' }])
     expect(result).to match_array(['使用', '√ẩŀứệ', '√ẩŀứệ'])
   end

spec/spec_helper_acceptance.rb

@@ -8,10 +8,6 @@
 install_module_on(hosts)
 install_module_dependencies_on(hosts)
 
-def return_puppet_version
-  (on default, puppet('--version')).output.chomp
-end
-
 RSpec.configure do |c|
   # Readable test descriptions
   c.formatter = :documentation