Rewrite validate_email_address() as a Puppet 4.x function

The 3.x function rely on is_email_address() which is deprecated. Rewrite
it using the more modern puppet 4.x function to rely on data types for
better parameters validation.

Author: smortex

lib/puppet/functions/validate_email_address.rb

@@ -0,0 +1,31 @@
+# frozen_string_literal: true
+
+# @summary
+#   Validate that all values passed are valid email addresses.
+#   Fail compilation if any value fails this check.
+Puppet::Functions.create_function(:validate_email_address) do
+  # @param values An e-mail address or an array of e-mail addresses to check
+  #
+  # @return [Undef]
+  #   Fail compilation if any value fails this check.
+  #
+  # @example Passing examples
+  #   $my_email = "waldo@gmail.com"
+  #   validate_email_address($my_email)
+  #   validate_email_address("bob@gmail.com", "alice@gmail.com", $my_email)
+  #
+  # @example Failing examples (causing compilation to abort)
+  #   $some_array = [ 'bad_email@/d/efdf.com' ]
+  #   validate_email_address($some_array)
+  dispatch :validate_email_address do
+    repeated_param 'Stdlib::Email', :values
+  end
+
+  def validate_email_address(*args)
+    assert_arg_count(args)
+  end
+
+  def assert_arg_count(args)
+    raise(ArgumentError, 'validate_email_address(): Wrong number of arguments need at least one') if args.empty?
+  end
+end

lib/puppet/parser/functions/validate_email_address.rb

@@ -5,7 +5,7 @@
 describe 'validate_email_address' do
   describe 'signature validation' do
     it { is_expected.not_to eq(nil) }
-    it { is_expected.to run.with_params.and_raise_error(Puppet::ParseError, %r{wrong number of arguments}i) }
+    it { is_expected.to run.with_params.and_raise_error(ArgumentError, %r{wrong number of arguments}i) }
   end
 
   describe 'valid inputs' do
@@ -14,12 +14,12 @@
   end
 
   describe 'invalid inputs' do
-    it { is_expected.to run.with_params({}).and_raise_error(Puppet::ParseError, %r{is not a string}) }
-    it { is_expected.to run.with_params(1).and_raise_error(Puppet::ParseError, %r{is not a string}) }
-    it { is_expected.to run.with_params(true).and_raise_error(Puppet::ParseError, %r{is not a string}) }
-    it { is_expected.to run.with_params('one').and_raise_error(Puppet::ParseError, %r{is not a valid email}) }
-    it { is_expected.to run.with_params('bob@gmail.com', {}).and_raise_error(Puppet::ParseError, %r{is not a string}) }
-    it { is_expected.to run.with_params('bob@gmail.com', true).and_raise_error(Puppet::ParseError, %r{is not a string}) }
-    it { is_expected.to run.with_params('bob@gmail.com', 'one').and_raise_error(Puppet::ParseError, %r{is not a valid email}) }
+    it { is_expected.to run.with_params({}).and_raise_error(ArgumentError, %r{got Hash}) }
+    it { is_expected.to run.with_params(1).and_raise_error(ArgumentError, %r{got Integer}) }
+    it { is_expected.to run.with_params(true).and_raise_error(ArgumentError, %r{got Boolean}) }
+    it { is_expected.to run.with_params('one').and_raise_error(ArgumentError, %r{got 'one'}) }
+    it { is_expected.to run.with_params('bob@gmail.com', {}).and_raise_error(ArgumentError, %r{got Hash}) }
+    it { is_expected.to run.with_params('bob@gmail.com', true).and_raise_error(ArgumentError, %r{got Boolean}) }
+    it { is_expected.to run.with_params('bob@gmail.com', 'one').and_raise_error(ArgumentError, %r{got 'one'}) }
   end
 end