fqdn_rotate: Don't use the value itself as part of the random seed

Author: elyscape

lib/puppet/parser/functions/fqdn_rotate.rb

@@ -11,7 +11,7 @@ module Puppet::Parser::Functions
     raise(Puppet::ParseError, "fqdn_rotate(): Wrong number of arguments " +
       "given (#{arguments.size} for 1)") if arguments.size < 1
 
-    value = arguments[0]
+    value = arguments.shift
     require 'digest/md5'
 
     unless value.is_a?(Array) || value.is_a?(String)

spec/acceptance/fqdn_rotate_spec.rb

@@ -36,7 +36,7 @@
       EOS
 
       apply_manifest(pp, :catch_failures => true) do |r|
-        expect(r.stdout).to match(/fqdn_rotate is \["c", "d", "a", "b"\]/)
+        expect(r.stdout).to match(/fqdn_rotate is \["d", "a", "b", "c"\]/)
       end
     end
   end

spec/functions/fqdn_rotate_spec.rb

@@ -44,7 +44,7 @@ class AlsoString < String
   it "should use the Puppet::Util.deterministic_rand function if available" do
     scope.expects(:lookupvar).with("::fqdn").returns("127.0.0.1")
     if Puppet::Util.respond_to?(:deterministic_rand)
-      Puppet::Util.expects(:deterministic_rand).with(113646079810780526294648115052177588845,4)
+      Puppet::Util.expects(:deterministic_rand).with(44489829212339698569024999901561968770,4)
     end
     scope.function_fqdn_rotate(["asdf"])
   end