(CONT-801) Unsafe autocorrect RSpec/BeEq

Author: LukasAud

.rubocop_todo.yml

@@ -96,11 +96,6 @@ Performance/CollectionLiteralInLoop:
   Exclude:
     - 'lib/puppet/functions/ensure_packages.rb'
 
-# Offense count: 95
-# This cop supports unsafe autocorrection (--autocorrect-all).
-RSpec/BeEq:
-  Enabled: false
-
 # Offense count: 36
 # Configuration parameters: Prefixes, AllowedPatterns.
 # Prefixes: when, with, without

spec/functions/any2array_spec.rb

@@ -3,7 +3,7 @@
 require 'spec_helper'
 
 describe 'any2array' do
-  it { is_expected.not_to eq(nil) }
+  it { is_expected.not_to be_nil }
   it { is_expected.to run.with_params.and_return([]) }
   it { is_expected.to run.with_params('').and_return([]) }
   it { is_expected.to run.with_params(true).and_return([true]) }

spec/functions/any2bool_spec.rb

@@ -3,7 +3,7 @@
 require 'spec_helper'
 
 describe 'any2bool' do
-  it { is_expected.not_to eq(nil) }
+  it { is_expected.not_to be_nil }
   it { is_expected.to run.with_params.and_raise_error(Puppet::ParseError, %r{wrong number of arguments}i) }
 
   it { is_expected.to run.with_params(true).and_return(true) }

spec/functions/base64_spec.rb

@@ -3,7 +3,7 @@
 require 'spec_helper'
 
 describe 'base64' do
-  it { is_expected.not_to eq(nil) }
+  it { is_expected.not_to be_nil }
   it { is_expected.to run.with_params.and_raise_error(Puppet::ParseError) }
   it { is_expected.to run.with_params('one').and_raise_error(Puppet::ParseError) }
   it { is_expected.to run.with_params('one', 'two').and_raise_error(Puppet::ParseError, %r{first argument must be one of}) }

spec/functions/basename_spec.rb

@@ -3,7 +3,7 @@
 require 'spec_helper'
 
 describe 'basename' do
-  it { is_expected.not_to eq(nil) }
+  it { is_expected.not_to be_nil }
   it { is_expected.to run.with_params.and_raise_error(Puppet::ParseError, %r{No arguments given}) }
   it { is_expected.to run.with_params('one', 'two', 'three').and_raise_error(Puppet::ParseError, %r{Too many arguments given}) }
   it { is_expected.to run.with_params([]).and_raise_error(Puppet::ParseError, %r{Requires string as first argument}) }

spec/functions/batch_escape_spec.rb

@@ -3,7 +3,7 @@
 require 'spec_helper'
 
 describe 'batch_escape' do
-  it { is_expected.not_to eq(nil) }
+  it { is_expected.not_to be_nil }
 
   describe 'signature validation' do
     it { is_expected.to run.with_params.and_raise_error(ArgumentError, %r{'batch_escape' expects 1 argument, got none}) }

spec/functions/bool2num_spec.rb

@@ -3,7 +3,7 @@
 require 'spec_helper'
 
 describe 'bool2num' do
-  it { is_expected.not_to eq(nil) }
+  it { is_expected.not_to be_nil }
   it { is_expected.to run.with_params.and_raise_error(Puppet::ParseError) }
 
   [true, 'true', 't', '1', 'y', 'yes', AlsoString.new('true')].each do |truthy|

spec/functions/bool2str_spec.rb

@@ -3,7 +3,7 @@
 require 'spec_helper'
 
 describe 'bool2str' do
-  it { is_expected.not_to eq(nil) }
+  it { is_expected.not_to be_nil }
   it { is_expected.to run.with_params.and_raise_error(Puppet::ParseError) }
 
   ['true', 'false', nil, :undef, ''].each do |invalid|

spec/functions/clamp_spec.rb

@@ -3,7 +3,7 @@
 require 'spec_helper'
 
 describe 'clamp' do
-  it { is_expected.not_to eq(nil) }
+  it { is_expected.not_to be_nil }
   it { is_expected.to run.with_params.and_raise_error(ArgumentError, %r{Wrong number of arguments}) }
   it { is_expected.to run.with_params([]).and_raise_error(Puppet::ParseError, %r{Wrong number of arguments}) }
   it { is_expected.to run.with_params(12, 88, 71, 190).and_raise_error(Puppet::ParseError, %r{Wrong number of arguments, need three to clamp}) }

spec/functions/concat_spec.rb

@@ -3,7 +3,7 @@
 require 'spec_helper'
 
 describe 'concat' do
-  it { is_expected.not_to eq(nil) }
+  it { is_expected.not_to be_nil }
   it { is_expected.to run.with_params.and_raise_error(Puppet::ParseError, %r{Wrong number of arguments}) }
   it { is_expected.to run.with_params([1]).and_raise_error(Puppet::ParseError, %r{Wrong number of arguments}) }
   it { is_expected.to run.with_params(1, [2]).and_raise_error(Puppet::ParseError, %r{Requires array}) }

spec/functions/convert_base_spec.rb

@@ -3,7 +3,7 @@
 require 'spec_helper'
 
 describe 'convert_base' do
-  it { is_expected.not_to eq(nil) }
+  it { is_expected.not_to be_nil }
   it { is_expected.to run.with_params.and_raise_error(ArgumentError) }
   it { is_expected.to run.with_params('asdf').and_raise_error(ArgumentError) }
   it { is_expected.to run.with_params('asdf', 'moo', 'cow').and_raise_error(ArgumentError) }

spec/functions/count_spec.rb

@@ -3,7 +3,7 @@
 require 'spec_helper'
 
 describe 'count' do
-  it { is_expected.not_to eq(nil) }
+  it { is_expected.not_to be_nil }
   it { is_expected.to run.with_params.and_raise_error(ArgumentError) }
   it { is_expected.to run.with_params('one').and_raise_error(ArgumentError) }
   it { is_expected.to run.with_params('one', 'two').and_return(1) }

spec/functions/crc32_spec.rb

@@ -4,7 +4,7 @@
 
 describe 'stdlib::crc32' do
   context 'when default' do
-    it { is_expected.not_to eq(nil) }
+    it { is_expected.not_to be_nil }
     it { is_expected.to run.with_params.and_raise_error(ArgumentError, %r{stdlib::crc32}) }
   end
 

spec/functions/delete_at_spec.rb

@@ -3,7 +3,7 @@
 require 'spec_helper'
 
 describe 'delete_at' do
-  it { is_expected.not_to eq(nil) }
+  it { is_expected.not_to be_nil }
   it { is_expected.to run.with_params.and_raise_error(Puppet::ParseError, %r{Wrong number of arguments}) }
   it { is_expected.to run.with_params('one', 1).and_raise_error(Puppet::ParseError, %r{Requires array}) }
   it { is_expected.to run.with_params(1, 1).and_raise_error(Puppet::ParseError, %r{Requires array}) }

spec/functions/delete_regex_spec.rb

@@ -3,7 +3,7 @@
 require 'spec_helper'
 
 describe 'delete_regex' do
-  it { is_expected.not_to eq(nil) }
+  it { is_expected.not_to be_nil }
   it { is_expected.to run.with_params.and_raise_error(Puppet::ParseError, %r{Wrong number of arguments}) }
   it { is_expected.to run.with_params([]).and_raise_error(Puppet::ParseError, %r{Wrong number of arguments}) }
   it { is_expected.to run.with_params([], 'two') }

spec/functions/delete_spec.rb

@@ -3,7 +3,7 @@
 require 'spec_helper'
 
 describe 'delete' do
-  it { is_expected.not_to eq(nil) }
+  it { is_expected.not_to be_nil }
   it { is_expected.to run.with_params.and_raise_error(Puppet::ParseError, %r{Wrong number of arguments}) }
   it { is_expected.to run.with_params([]).and_raise_error(Puppet::ParseError, %r{Wrong number of arguments}) }
   it { is_expected.to run.with_params([], 'two') }

spec/functions/delete_undef_values_spec.rb

@@ -5,7 +5,7 @@
 describe 'delete_undef_values' do
   let(:is_puppet_6) { Puppet::Util::Package.versioncmp(Puppet.version, '6.0.0') == 0 }
 
-  it { is_expected.not_to eq(nil) }
+  it { is_expected.not_to be_nil }
   it { is_expected.to run.with_params.and_raise_error(Puppet::ParseError, %r{Wrong number of arguments}) }
   it { is_expected.to run.with_params(1).and_raise_error(Puppet::ParseError, %r{expected an array or hash}) }
   it { is_expected.to run.with_params('one').and_raise_error(Puppet::ParseError, %r{expected an array or hash}) }

spec/functions/delete_values_spec.rb

@@ -3,7 +3,7 @@
 require 'spec_helper'
 
 describe 'delete_values' do
-  it { is_expected.not_to eq(nil) }
+  it { is_expected.not_to be_nil }
   it { is_expected.to run.with_params.and_raise_error(Puppet::ParseError, %r{Wrong number of arguments}) }
   it { is_expected.to run.with_params(1).and_raise_error(Puppet::ParseError, %r{Wrong number of arguments}) }
   it { is_expected.to run.with_params('one').and_raise_error(Puppet::ParseError, %r{Wrong number of arguments}) }

spec/functions/deprecation_spec.rb

@@ -14,7 +14,7 @@
       Puppet.settings[:strict] = :warning
     end
 
-    it { is_expected.not_to eq(nil) }
+    it { is_expected.not_to be_nil }
     it { is_expected.to run.with_params.and_raise_error(ArgumentError) }
 
     it 'displays a single warning' do
@@ -66,7 +66,7 @@
       ENV['STDLIB_LOG_DEPRECATIONS'] = 'true'
     end
 
-    it { is_expected.not_to eq(nil) }
+    it { is_expected.not_to be_nil }
     it { is_expected.to run.with_params.and_raise_error(Puppet::ParseError, %r{wrong number of arguments}i) }
 
     it 'displays a single warning' do

spec/functions/difference_spec.rb

@@ -3,7 +3,7 @@
 require 'spec_helper'
 
 describe 'difference' do
-  it { is_expected.not_to eq(nil) }
+  it { is_expected.not_to be_nil }
   it { is_expected.to run.with_params.and_raise_error(Puppet::ParseError, %r{Wrong number of arguments}) }
   it { is_expected.to run.with_params('one').and_raise_error(Puppet::ParseError, %r{Wrong number of arguments}) }
   it { is_expected.to run.with_params('one', 'two').and_raise_error(Puppet::ParseError, %r{Requires 2 arrays}) }

spec/functions/dirname_spec.rb

@@ -3,7 +3,7 @@
 require 'spec_helper'
 
 describe 'dirname' do
-  it { is_expected.not_to eq(nil) }
+  it { is_expected.not_to be_nil }
   it { is_expected.to run.with_params.and_raise_error(Puppet::ParseError, %r{No arguments given}) }
   it { is_expected.to run.with_params('one', 'two').and_raise_error(Puppet::ParseError, %r{Too many arguments given}) }
   it { is_expected.to run.with_params([]).and_raise_error(Puppet::ParseError, %r{Requires string as argument}) }

spec/functions/dos2unix_spec.rb

@@ -4,7 +4,7 @@
 
 describe 'dos2unix' do
   context 'when checking parameter validity' do
-    it { is_expected.not_to eq(nil) }
+    it { is_expected.not_to be_nil }
 
     it do
       expect(subject).to run.with_params.and_raise_error(ArgumentError, %r{Wrong number of arguments})

spec/functions/ensure_packages_spec.rb

@@ -3,7 +3,7 @@
 require 'spec_helper'
 
 describe 'ensure_packages' do
-  it { is_expected.not_to eq(nil) }
+  it { is_expected.not_to be_nil }
   it { is_expected.to run.with_params('packagename') }
   it { is_expected.to run.with_params(['packagename1', 'packagename2']) }
 

spec/functions/ensure_resource_spec.rb

@@ -3,7 +3,7 @@
 require 'spec_helper'
 
 describe 'ensure_resource' do
-  it { is_expected.not_to eq(nil) }
+  it { is_expected.not_to be_nil }
   it { is_expected.to run.with_params.and_raise_error(ArgumentError, %r{Must specify a type}) }
   it { is_expected.to run.with_params('type').and_raise_error(ArgumentError, %r{Must specify a title}) }
 

spec/functions/ensure_resources_spec.rb

@@ -3,7 +3,7 @@
 require 'spec_helper'
 
 describe 'ensure_resources' do
-  it { is_expected.not_to eq(nil) }
+  it { is_expected.not_to be_nil }
   it { is_expected.to run.with_params.and_raise_error(ArgumentError, %r{Must specify a type}) }
   it { is_expected.to run.with_params('type').and_raise_error(ArgumentError, %r{Must specify a title}) }
 

spec/functions/extname_spec.rb

@@ -3,7 +3,7 @@
 require 'spec_helper'
 
 describe 'stdlib::extname' do
-  it { is_expected.not_to eq(nil) }
+  it { is_expected.not_to be_nil }
   it { is_expected.to run.with_params.and_raise_error(ArgumentError, %r{'stdlib::extname' expects 1 argument, got none}) }
   it { is_expected.to run.with_params('one', 'two').and_raise_error(ArgumentError, %r{'stdlib::extname' expects 1 argument, got 2}) }
   it { is_expected.to run.with_params([]).and_raise_error(ArgumentError, %r{'stdlib::extname' parameter 'filename' expects a String value, got Array}) }

spec/functions/fqdn_rand_string_spec.rb

@@ -5,7 +5,7 @@
 describe 'fqdn_rand_string' do
   let(:default_charset) { %r{\A[a-zA-Z0-9]{100}\z} }
 
-  it { is_expected.not_to eq(nil) }
+  it { is_expected.not_to be_nil }
   it { is_expected.to run.with_params.and_raise_error(ArgumentError, %r{expects at least 1 argument, got none}i) }
   it { is_expected.to run.with_params(0).and_raise_error(ArgumentError, %r{parameter 'length' expects an Integer\[1\] value, got Integer\[0, 0\]}) }
   it { is_expected.to run.with_params(1.5).and_raise_error(ArgumentError, %r{parameter 'length' expects an Integer\ value, got Float}) }

spec/functions/fqdn_rotate_spec.rb

@@ -3,7 +3,7 @@
 require 'spec_helper'
 
 describe 'fqdn_rotate' do
-  it { is_expected.not_to eq(nil) }
+  it { is_expected.not_to be_nil }
   it { is_expected.to run.with_params.and_raise_error(Puppet::ParseError, %r{wrong number of arguments}i) }
   it { is_expected.to run.with_params(0).and_raise_error(Puppet::ParseError, %r{Requires either array or string to work with}) }
   it { is_expected.to run.with_params({}).and_raise_error(Puppet::ParseError, %r{Requires either array or string to work with}) }

spec/functions/get_module_path_spec.rb

@@ -3,7 +3,7 @@
 require 'spec_helper'
 
 describe 'get_module_path' do
-  it { is_expected.not_to eq(nil) }
+  it { is_expected.not_to be_nil }
   it { is_expected.to run.with_params.and_raise_error(Puppet::ParseError, %r{Wrong number of arguments, expects one}) }
   it { is_expected.to run.with_params('one', 'two').and_raise_error(Puppet::ParseError, %r{Wrong number of arguments, expects one}) }
   it { is_expected.to run.with_params('one', 'two', 'three').and_raise_error(Puppet::ParseError, %r{Wrong number of arguments, expects one}) }

spec/functions/getparam_spec.rb

@@ -3,7 +3,7 @@
 require 'spec_helper'
 
 describe 'getparam' do
-  it { is_expected.not_to eq(nil) }
+  it { is_expected.not_to be_nil }
   it { is_expected.to run.with_params.and_raise_error(ArgumentError, %r{Must specify a reference}) }
   it { is_expected.to run.with_params('User[one]').and_raise_error(ArgumentError, %r{Must specify name of a parameter}) }
   it { is_expected.to run.with_params('User[one]', 2).and_raise_error(ArgumentError, %r{Must specify name of a parameter}) }

spec/functions/glob_spec.rb

@@ -3,7 +3,7 @@
 require 'spec_helper'
 
 describe 'glob' do
-  it { is_expected.not_to eq(nil) }
+  it { is_expected.not_to be_nil }
   it { is_expected.to run.with_params.and_raise_error(Puppet::ParseError) }
   it { is_expected.to run.with_params(1).and_raise_error(Puppet::ParseError) }
   it { is_expected.to run.with_params('').and_return([]) }

spec/functions/grep_spec.rb

@@ -3,7 +3,7 @@
 require 'spec_helper'
 
 describe 'grep' do
-  it { is_expected.not_to eq(nil) }
+  it { is_expected.not_to be_nil }
   it { is_expected.to run.with_params.and_raise_error(Puppet::ParseError, %r{wrong number of arguments}i) }
   it { is_expected.to run.with_params('one').and_raise_error(Puppet::ParseError, %r{wrong number of arguments}i) }
 

spec/functions/has_interface_with_spec.rb

@@ -3,7 +3,7 @@
 require 'spec_helper'
 
 describe 'has_interface_with' do
-  it { is_expected.not_to eq(nil) }
+  it { is_expected.not_to be_nil }
   it { is_expected.to run.with_params.and_raise_error(ArgumentError, %r{expects between 1 and 2 arguments, got none}) }
   it { is_expected.to run.with_params('one', 'two', 'three').and_raise_error(ArgumentError, %r{expects between 1 and 2 arguments, got 3}) }
 

spec/functions/has_ip_address_spec.rb

@@ -3,7 +3,7 @@
 require 'spec_helper'
 
 describe 'has_ip_address' do
-  it { is_expected.not_to eq(nil) }
+  it { is_expected.not_to be_nil }
   it { is_expected.to run.with_params.and_raise_error(Puppet::ParseError, %r{wrong number of arguments}i) }
   it { is_expected.to run.with_params('one', 'two').and_raise_error(Puppet::ParseError, %r{wrong number of arguments}i) }
 

spec/functions/has_ip_network_spec.rb

@@ -3,7 +3,7 @@
 require 'spec_helper'
 
 describe 'has_ip_network' do
-  it { is_expected.not_to eq(nil) }
+  it { is_expected.not_to be_nil }
   it { is_expected.to run.with_params.and_raise_error(Puppet::ParseError, %r{wrong number of arguments}i) }
   it { is_expected.to run.with_params('one', 'two').and_raise_error(Puppet::ParseError, %r{wrong number of arguments}i) }
 

spec/functions/intersection_spec.rb

@@ -3,7 +3,7 @@
 require 'spec_helper'
 
 describe 'intersection' do
-  it { is_expected.not_to eq(nil) }
+  it { is_expected.not_to be_nil }
   it { is_expected.to run.with_params.and_raise_error(Puppet::ParseError) }
   it { is_expected.to run.with_params('one').and_raise_error(Puppet::ParseError) }
   it { is_expected.to run.with_params('one', 'two').and_raise_error(Puppet::ParseError) }

spec/functions/ip_in_range_spec.rb

@@ -4,7 +4,7 @@
 
 describe 'stdlib::ip_in_range' do
   describe 'signature validation' do
-    it { is_expected.not_to eq(nil) }
+    it { is_expected.not_to be_nil }
     it { is_expected.to run.with_params.and_raise_error(ArgumentError, %r{'stdlib::ip_in_range' expects 2 arguments, got none}) }
     it { is_expected.to run.with_params('one', 'two', '3').and_raise_error(ArgumentError, %r{'stdlib::ip_in_range' expects 2 arguments, got 3}) }
     it { is_expected.to run.with_params([], []).and_raise_error(ArgumentError, %r{'stdlib::ip_in_range' parameter 'ipaddress' expects a String value, got Array}) }

spec/functions/is_a_spec.rb

@@ -5,14 +5,14 @@
 if ENV['FUTURE_PARSER'] == 'yes'
   describe 'type_of' do
     pending 'teach rspec-puppet to load future-only functions under 3.7.5' do
-      it { is_expected.not_to eq(nil) }
+      it { is_expected.not_to be_nil }
     end
   end
 end
 
 if Puppet.version.to_f >= 4.0
   describe 'is_a' do
-    it { is_expected.not_to eq(nil) }
+    it { is_expected.not_to be_nil }
     it { is_expected.to run.with_params.and_raise_error(ArgumentError) }
     it { is_expected.to run.with_params('', '').and_raise_error(ArgumentError) }
 

spec/functions/join_keys_to_values_spec.rb

@@ -3,7 +3,7 @@
 require 'spec_helper'
 
 describe 'join_keys_to_values' do
-  it { is_expected.not_to eq(nil) }
+  it { is_expected.not_to be_nil }
   it { is_expected.to run.with_params.and_raise_error(Puppet::ParseError, %r{Takes exactly two arguments}) }
   it { is_expected.to run.with_params({}, '', '').and_raise_error(Puppet::ParseError, %r{Takes exactly two arguments}) }
   it { is_expected.to run.with_params('one', '').and_raise_error(TypeError, %r{The first argument must be a hash}) }

spec/functions/load_module_metadata_spec.rb

@@ -3,7 +3,7 @@
 require 'spec_helper'
 
 describe 'load_module_metadata' do
-  it { is_expected.not_to eq(nil) }
+  it { is_expected.not_to be_nil }
   it { is_expected.to run.with_params.and_raise_error(Puppet::ParseError, %r{wrong number of arguments}i) }
   it { is_expected.to run.with_params('one', 'two', 'three').and_raise_error(Puppet::ParseError, %r{wrong number of arguments}i) }
 

spec/functions/loadjson_spec.rb

@@ -3,7 +3,7 @@
 require 'spec_helper'
 
 describe 'loadjson' do
-  it { is_expected.not_to eq(nil) }
+  it { is_expected.not_to be_nil }
   it { is_expected.to run.with_params.and_raise_error(ArgumentError, %r{wrong number of arguments}i) }
 
   describe 'when calling with valid arguments' do

spec/functions/loadyaml_spec.rb

@@ -3,7 +3,7 @@
 require 'spec_helper'
 
 describe 'loadyaml' do
-  it { is_expected.not_to eq(nil) }
+  it { is_expected.not_to be_nil }
   it { is_expected.to run.with_params.and_raise_error(ArgumentError, %r{wrong number of arguments}i) }
 
   context 'when a non-existing file is specified' do