RubocopFunctionsFinished

Author: David Swan

.rubocop.yml

@@ -95,4 +95,6 @@ Style/AsciiComments:
 Style/IfUnlessModifier:
   Enabled: false
 Style/SymbolProc:
-  Enabled: false
+  Enabled: false
+RSpec/NamedSubject:
+ Enabled: false

spec/functions/deep_merge_spec.rb

@@ -46,7 +46,7 @@
   arguments = { 'key1' => 'value1' }, { 'key2' => 'value2' }
   originals = [arguments[0].dup, arguments[1].dup]
   it 'does not change the original hashes' do
-    subject.call([arguments[0], arguments[1]]) # rubocop:disable RSpec/NamedSubject
+    subject.call([arguments[0], arguments[1]])
     arguments.each_with_index do |argument, index|
       expect(argument).to eq(originals[index])
     end

spec/functions/get_module_path_spec.rb

@@ -25,7 +25,7 @@ def initialize(path)
 
       it { is_expected.to run.with_params('foo').and_return(path_of_module_foo.path) }
 
-      context 'when the modulepath is a list' do
+      context 'when the modulepath is a list' do # rubocop:disable RSpec/NestedGroups
         before(:each) { Puppet[:modulepath] = modulepath + 'tmp/something_else' }
 
         it { is_expected.to run.with_params('foo').and_return(path_of_module_foo.path) }
@@ -39,7 +39,7 @@ def initialize(path)
 
       it { is_expected.to run.with_params('foo').and_return(path_of_module_foo.path) }
 
-      context 'when the modulepath is a list' do
+      context 'when the modulepath is a list' do # rubocop:disable RSpec/NestedGroups
         before(:each) { Puppet[:modulepath] = modulepath + 'tmp/something_else' }
 
         it { is_expected.to run.with_params('foo').and_return(path_of_module_foo.path) }

spec/functions/getvar_spec.rb

@@ -4,7 +4,6 @@
   it { is_expected.not_to eq(nil) }
   it { is_expected.to run.with_params.and_raise_error(Puppet::ParseError, %r{wrong number of arguments}i) }
   it { is_expected.to run.with_params('one', 'two').and_raise_error(Puppet::ParseError, %r{wrong number of arguments}i) }
-  it { is_expected.to run.with_params.and_raise_error(Puppet::ParseError, %r{wrong number of arguments}i) }
 
   it { is_expected.to run.with_params('$::foo').and_return(nil) }
 

spec/functions/is_a_spec.rb

@@ -23,8 +23,10 @@
     end
 
     it 'suceeds when comparing an UTF8 and double byte characters' do
-      is_expected.to run.with_params('このテキスト', String).and_return(true)
-      is_expected.to run.with_params('ŧћịś ŧêχŧ', String).and_return(true)
+      comparison_array = ['このテキスト', 'ŧћịś ŧêχŧ']
+      comparison_array.each do |comparison_value|
+        is_expected.to run.with_params(comparison_value, String).and_return(true)
+      end
     end
   end
 end

spec/functions/is_array_spec.rb

@@ -17,7 +17,7 @@
   it { is_expected.to run.with_params(1).and_return(false) }
   it { is_expected.to run.with_params({}).and_return(false) }
   context 'Checking for deprecation warning' do
-    after(:all) do
+    after(:each) do
       ENV.delete('STDLIB_LOG_DEPRECATIONS')
     end
     # Checking for deprecation warning, which should only be provoked when the env variable for it is set.

spec/functions/is_bool_spec.rb

@@ -13,7 +13,7 @@
   it { is_expected.to run.with_params('true').and_return(false) }
   it { is_expected.to run.with_params('false').and_return(false) }
   context 'Checking for deprecation warning' do
-    after(:all) do
+    after(:each) do
       ENV.delete('STDLIB_LOG_DEPRECATIONS')
     end
     # Checking for deprecation warning, which should only be provoked when the env variable for it is set.

spec/functions/is_domain_name_spec.rb

@@ -28,7 +28,7 @@
     it { is_expected.to run.with_params('www.foo-bar.example.com').and_return(true) }
     it { is_expected.to run.with_params('www.foo-bar.example.com.').and_return(true) }
     it { is_expected.to run.with_params('-foo.example.com').and_return(false) }
-    it { is_expected.to run.with_params('-foo.example.com').and_return(false) }
+    it { is_expected.to run.with_params('-foo.example.com.').and_return(false) }
   end
   # Values obtained from Facter values will be frozen strings
   # in newer versions of Facter:

spec/functions/is_float_spec.rb

@@ -22,7 +22,7 @@
   end
 
   context 'Checking for deprecation warning' do
-    after(:all) do
+    after(:each) do
       ENV.delete('STDLIB_LOG_DEPRECATIONS')
     end
     # Checking for deprecation warning, which should only be provoked when the env variable for it is set.

spec/functions/is_integer_spec.rb

@@ -16,7 +16,7 @@
   it { is_expected.to run.with_params(3.7).and_return(false) }
   it { is_expected.to run.with_params('3.7').and_return(false) }
   it { is_expected.to run.with_params(-3.7).and_return(false) }
-  it { is_expected.to run.with_params('3.7').and_return(false) }
+  it { is_expected.to run.with_params('-3.7').and_return(false) }
 
   it { is_expected.to run.with_params('one').and_return(false) }
   it { is_expected.to run.with_params([]).and_return(false) }
@@ -28,7 +28,7 @@
   it { is_expected.to run.with_params("foo\nbar").and_return(false) }
 
   context 'Checking for deprecation warning' do
-    after(:all) do
+    after(:each) do
       ENV.delete('STDLIB_LOG_DEPRECATIONS')
     end
     # Checking for deprecation warning, which should only be provoked when the env variable for it is set.

spec/functions/is_ip_address_spec.rb

@@ -33,7 +33,7 @@
       scope.expects(:warning).with(includes('This method is deprecated')).never
       is_expected.to run.with_params('1.2.3.4').and_return(true)
     end
-    after(:all) do
+    after(:each) do
       ENV.delete('STDLIB_LOG_DEPRECATIONS')
     end
   end

spec/functions/is_ipv4_address_spec.rb

@@ -13,7 +13,7 @@
   end
 
   context 'Checking for deprecation warning', if: Puppet.version.to_f < 4.0 do
-    after(:all) do
+    after(:each) do
       ENV.delete('STDLIB_LOG_DEPRECATIONS')
     end
     # Checking for deprecation warning, which should only be provoked when the env variable for it is set.

spec/functions/is_ipv6_address_spec.rb

@@ -11,7 +11,7 @@
   it { is_expected.to run.with_params('one').and_return(false) }
 
   context 'Checking for deprecation warning', if: Puppet.version.to_f < 4.0 do
-    after(:all) do
+    after(:each) do
       ENV.delete('STDLIB_LOG_DEPRECATIONS')
     end
     # Checking for deprecation warning, which should only be provoked when the env variable for it is set.

spec/functions/is_numeric_spec.rb

@@ -14,7 +14,7 @@
   it { is_expected.to run.with_params(3.7).and_return(true) }
   it { is_expected.to run.with_params('3.7').and_return(true) }
   it { is_expected.to run.with_params(-3.7).and_return(true) }
-  it { is_expected.to run.with_params('3.7').and_return(true) }
+  it { is_expected.to run.with_params('-3.7').and_return(true) }
 
   it { is_expected.to run.with_params('-342.2315e-12').and_return(true) }
 
@@ -28,7 +28,7 @@
   it { is_expected.to run.with_params(' - 1234').and_return(false) }
 
   context 'Checking for deprecation warning' do
-    after(:all) do
+    after(:each) do
       ENV.delete('STDLIB_LOG_DEPRECATIONS')
     end
     # Checking for deprecation warning, which should only be provoked when the env variable for it is set.

spec/functions/is_string_spec.rb

@@ -16,7 +16,7 @@
   it { is_expected.to run.with_params(3.7).and_return(false) }
   it { is_expected.to run.with_params('3.7').and_return(false) }
   it { is_expected.to run.with_params(-3.7).and_return(false) }
-  it { is_expected.to run.with_params('3.7').and_return(false) }
+  it { is_expected.to run.with_params('-3.7').and_return(false) }
 
   it { is_expected.to run.with_params([]).and_return(false) }
   it { is_expected.to run.with_params([1]).and_return(false) }
@@ -27,7 +27,7 @@
   it { is_expected.to run.with_params('0001234').and_return(true) }
 
   context 'Checking for deprecation warning' do
-    after(:all) do
+    after(:each) do
       ENV.delete('STDLIB_LOG_DEPRECATIONS')
     end
     # Checking for deprecation warning, which should only be provoked when the env variable for it is set.

spec/functions/load_module_metadata_spec.rb

@@ -7,52 +7,38 @@
 
   describe 'when calling with valid arguments' do
     before :each do
-      allow(File).to receive(:read).with(/\/(stdlib|test)\/metadata.json/, encoding: 'utf-8').and_return('{"name": "puppetlabs-stdlib"}')
-      allow(File).to receive(:read).with(/\/(stdlib|test)\/metadata.json/).and_return('{"name": "puppetlabs-stdlib"}')
+      allow(File).to receive(:read).with(%r{\/(stdlib|test)\/metadata.json}, encoding: 'utf-8').and_return('{"name": "puppetlabs-stdlib"}')
+      allow(File).to receive(:read).with(%r{\/(stdlib|test)\/metadata.json}).and_return('{"name": "puppetlabs-stdlib"}')
     end
 
     context 'when calling with valid utf8 and double byte character arguments' do
       before :each do
-        allow(File).to receive(:read).with(/\/(stdlib|test)\/metadata.json/, encoding: 'utf-8').and_return('{"ĭďèʼnţĩƒіểя": "ċơņťęאּť ỡƒ ţħíš -
+        allow(File).to receive(:read).with(%r{\/(stdlib|test)\/metadata.json}, encoding: 'utf-8').and_return('{"ĭďèʼnţĩƒіểя": "ċơņťęאּť ỡƒ ţħíš -
 この文字"}')
-        allow(File).to receive(:read).with(/\/(stdlib|test)\/metadata.json/).and_return('{"ĭďèʼnţĩƒіểя": "ċơņťęאּť ỡƒ ţħíš -
+        allow(File).to receive(:read).with(%r{\/(stdlib|test)\/metadata.json}).and_return('{"ĭďèʼnţĩƒіểя": "ċơņťęאּť ỡƒ ţħíš -
 この文字"}')
       end
 
+      let(:prefix) { 'C:' if Puppet::Util::Platform.windows? }
+
       it 'jsons parse the file' do
-        if Puppet::Util::Platform.windows?
-          allow(scope).to receive(:function_get_module_path).with(['science']).and_return('C:/path/to/module/')
-          allow(File).to receive(:exists?).with('C:/path/to/module/metadata.json').and_return(true)
-          allow(File).to receive(:read).with('C:/path/to/module/metadata.json').and_return('{"name": "spencer-science"}')
-        else
-          allow(scope).to receive(:function_get_module_path).with(['science']).and_return('/path/to/module/')
-          allow(File).to receive(:exists?).with('/path/to/module/metadata.json').and_return(true)
-          allow(File).to receive(:read).with('/path/to/module/metadata.json').and_return('{"name": "spencer-science"}')
-        end
+        allow(scope).to receive(:function_get_module_path).with(['science']).and_return("#{prefix}/path/to/module/")
+        allow(File).to receive(:exists?).with("#{prefix}/path/to/module/metadata.json").and_return(true)
+        allow(File).to receive(:read).with("#{prefix}/path/to/module/metadata.json").and_return('{"name": "spencer-science"}')
 
         result = subject.call(['science'])
         expect(result['name']).to eq('spencer-science')
       end
 
       it 'fails by default if there is no metadata.json' do
-        if Puppet::Util::Platform.windows?
-          allow(scope).to receive(:function_get_module_path).with(['science']).and_return('C:/path/to/module/')
-          allow(File).to receive(:exists?).with('C:/path/to/module/metadata.json').and_return(false)
-        else
-          allow(scope).to receive(:function_get_module_path).with(['science']).and_return('/path/to/module/')
-          allow(File).to receive(:exists?).with('/path/to/module/metadata.json').and_return(false)
-        end
+        allow(scope).to receive(:function_get_module_path).with(['science']).and_return("#{prefix}/path/to/module/")
+        allow(File).to receive(:exists?).with("#{prefix}/path/to/module/metadata.json").and_return(false)
         expect { subject.call(['science']) }.to raise_error(Puppet::ParseError)
       end
 
       it 'returns nil if user allows empty metadata.json' do
-        if Puppet::Util::Platform.windows?
-          allow(scope).to receive(:function_get_module_path).with(['science']).and_return('C:/path/to/module/')
-          allow(File).to receive(:exists?).with('C:/path/to/module/metadata.json').and_return(false)
-        else
-          allow(scope).to receive(:function_get_module_path).with(['science']).and_return('/path/to/module/')
-          allow(File).to receive(:exists?).with('/path/to/module/metadata.json').and_return(false)
-        end
+        allow(scope).to receive(:function_get_module_path).with(['science']).and_return("#{prefix}/path/to/module/")
+        allow(File).to receive(:exists?).with("#{prefix}/path/to/module/metadata.json").and_return(false)
         result = subject.call(['science', true])
         expect(result).to eq({})
       end

spec/functions/loadjson_spec.rb

@@ -6,8 +6,8 @@
 
   describe 'when calling with valid arguments' do
     before :each do
-      allow(File).to receive(:read).with(/\/(stdlib|test)\/metadata.json/, encoding: 'utf-8').and_return('{"name": "puppetlabs-stdlib"}')
-      allow(File).to receive(:read).with(/\/(stdlib|test)\/metadata.json/).and_return('{"name": "puppetlabs-stdlib"}')
+      allow(File).to receive(:read).with(%r{\/(stdlib|test)\/metadata.json}, encoding: 'utf-8').and_return('{"name": "puppetlabs-stdlib"}')
+      allow(File).to receive(:read).with(%r{\/(stdlib|test)\/metadata.json}).and_return('{"name": "puppetlabs-stdlib"}')
     end
 
     context 'when a non-existing file is specified' do

spec/functions/parsejson_spec.rb

@@ -22,10 +22,11 @@
     end
 
     it 'is able to parse empty JSON values' do
-      is_expected.to run.with_params('[]')
-                        .and_return([])
-      is_expected.to run.with_params('{}')
-                        .and_return({})
+      actual_array = %w[[] {}]
+      expected = [[], {}]
+      actual_array.each_with_index do |actual, index|
+        is_expected.to run.with_params(actual).and_return(expected[index])
+      end
     end
 
     it 'is able to parse JSON data with a mixed structure' do

spec/functions/parseyaml_spec.rb

@@ -12,10 +12,10 @@
 
   context 'with correct YAML data' do
     it 'is able to parse a YAML data with a String' do
-      is_expected.to run.with_params('--- just a string')
-                        .and_return('just a string')
-      is_expected.to run.with_params('just a string')
-                        .and_return('just a string')
+      actual_array = ['--- just a string', 'just a string']
+      actual_array.each do |actual|
+        is_expected.to run.with_params(actual).and_return('just a string')
+      end
     end
 
     it 'is able to parse YAML data with a Hash' do

spec/functions/private_spec.rb

@@ -2,10 +2,10 @@
 
 describe 'private' do
   it 'issues a warning' do
-    scope.expects(:warning).with("private() DEPRECATED: This function will cease to function on Puppet 4; please use assert_private() before upgrading to puppet 4 for backwards-compatibility, or migrate to the new parser's typing system.")
+    scope.expects(:warning).with("private() DEPRECATED: This function will cease to function on Puppet 4; please use assert_private() before upgrading to puppet 4 for backwards-compatibility, or migrate to the new parser's typing system.") # rubocop:disable Metrics/LineLength : unable to cut line to required length
     begin
       subject.call []
-    rescue
+    rescue # rubocop:disable Lint/HandleExceptions
       # ignore this
     end
   end
@@ -36,9 +36,7 @@
       scope.expects(:lookupvar).with('caller_module_name').returns('bar')
       scope.source.expects(:name).returns('foo::baz')
       scope.source.expects(:type).returns('hostclass')
-      expect {
-        subject.call []
-      }.to raise_error Puppet::ParseError, %r{Class foo::baz is private}
+      expect { subject.call [] }.to raise_error Puppet::ParseError, %r{Class foo::baz is private}
     end
   end
 
@@ -48,9 +46,7 @@
       scope.expects(:lookupvar).with('caller_module_name').returns('bar')
       scope.source.expects(:name).returns('foo::baz')
       scope.source.expects(:type).returns('definition')
-      expect {
-        subject.call []
-      }.to raise_error Puppet::ParseError, %r{Definition foo::baz is private}
+      expect { subject.call [] }.to raise_error Puppet::ParseError, %r{Definition foo::baz is private}
     end
   end
 end

spec/functions/pw_hash_spec.rb

@@ -53,7 +53,7 @@
   end
 
   context 'when running on a platform with a weak String#crypt implementation' do
-    before(:each) { allow_any_instance_of(String).to receive(:crypt).with('$1$1').and_return('a bad hash') }
+    before(:each) { allow_any_instance_of(String).to receive(:crypt).with('$1$1').and_return('a bad hash') } # rubocop:disable RSpec/AnyInstance : Unable to find a viable replacement
 
     it { is_expected.to run.with_params('password', 'sha-512', 'salt').and_raise_error(Puppet::ParseError, %r{system does not support enhanced salts}) }
   end
@@ -68,7 +68,10 @@
     if Puppet::Util::Package.versioncmp(Puppet.version, '4.7.0') >= 0
       describe 'when arguments are sensitive' do
         it { is_expected.to run.with_params(Puppet::Pops::Types::PSensitiveType::Sensitive.new('password'), 'md5', 'salt').and_return('$1$salt$qJH7.N4xYta3aEG/dfqo/0') }
-        it { is_expected.to run.with_params(Puppet::Pops::Types::PSensitiveType::Sensitive.new('password'), 'md5', Puppet::Pops::Types::PSensitiveType::Sensitive.new('salt')).and_return('$1$salt$qJH7.N4xYta3aEG/dfqo/0') }
+        it {
+          is_expected.to run.with_params(Puppet::Pops::Types::PSensitiveType::Sensitive.new('password'), 'md5', Puppet::Pops::Types::PSensitiveType::Sensitive.new('salt'))
+                            .and_return('$1$salt$qJH7.N4xYta3aEG/dfqo/0')
+        }
         it { is_expected.to run.with_params('password', 'md5', Puppet::Pops::Types::PSensitiveType::Sensitive.new('salt')).and_return('$1$salt$qJH7.N4xYta3aEG/dfqo/0') }
       end
     end